Commit 69c48846 authored by Jenny Derzhavetz's avatar Jenny Derzhavetz Committed by Nicholas Bellinger

iser-target: Remove redundant wait in release_conn

With current termination flow we call release_conn after completion.
Signed-off-by: default avatarJenny Derzhavetz <jennyf@mellanox.com>
Signed-off-by: default avatarSagi Grimberg <sagig@mellanox.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 6d1fba0c
...@@ -583,7 +583,6 @@ isert_init_conn(struct isert_conn *isert_conn) ...@@ -583,7 +583,6 @@ isert_init_conn(struct isert_conn *isert_conn)
INIT_LIST_HEAD(&isert_conn->node); INIT_LIST_HEAD(&isert_conn->node);
init_completion(&isert_conn->login_comp); init_completion(&isert_conn->login_comp);
init_completion(&isert_conn->login_req_comp); init_completion(&isert_conn->login_req_comp);
init_completion(&isert_conn->wait);
kref_init(&isert_conn->kref); kref_init(&isert_conn->kref);
mutex_init(&isert_conn->mutex); mutex_init(&isert_conn->mutex);
spin_lock_init(&isert_conn->pool_lock); spin_lock_init(&isert_conn->pool_lock);
...@@ -834,7 +833,6 @@ isert_handle_unbound_conn(struct isert_conn *isert_conn) ...@@ -834,7 +833,6 @@ isert_handle_unbound_conn(struct isert_conn *isert_conn)
*/ */
list_del_init(&isert_conn->node); list_del_init(&isert_conn->node);
isert_put_conn(isert_conn); isert_put_conn(isert_conn);
complete(&isert_conn->wait);
queue_work(isert_release_wq, &isert_conn->release_work); queue_work(isert_release_wq, &isert_conn->release_work);
} }
mutex_unlock(&isert_np->mutex); mutex_unlock(&isert_np->mutex);
...@@ -867,9 +865,6 @@ isert_conn_terminate(struct isert_conn *isert_conn) ...@@ -867,9 +865,6 @@ isert_conn_terminate(struct isert_conn *isert_conn)
if (err) if (err)
isert_warn("Failed rdma_disconnect isert_conn %p\n", isert_warn("Failed rdma_disconnect isert_conn %p\n",
isert_conn); isert_conn);
isert_info("conn %p completing wait\n", isert_conn);
complete(&isert_conn->wait);
} }
static int static int
...@@ -3274,8 +3269,6 @@ static void isert_release_work(struct work_struct *work) ...@@ -3274,8 +3269,6 @@ static void isert_release_work(struct work_struct *work)
isert_info("Starting release conn %p\n", isert_conn); isert_info("Starting release conn %p\n", isert_conn);
wait_for_completion(&isert_conn->wait);
mutex_lock(&isert_conn->mutex); mutex_lock(&isert_conn->mutex);
isert_conn->state = ISER_CONN_DOWN; isert_conn->state = ISER_CONN_DOWN;
mutex_unlock(&isert_conn->mutex); mutex_unlock(&isert_conn->mutex);
......
...@@ -201,7 +201,6 @@ struct isert_conn { ...@@ -201,7 +201,6 @@ struct isert_conn {
struct ib_qp *qp; struct ib_qp *qp;
struct isert_device *device; struct isert_device *device;
struct mutex mutex; struct mutex mutex;
struct completion wait;
struct completion wait_comp_err; struct completion wait_comp_err;
struct kref kref; struct kref kref;
struct list_head fr_pool; struct list_head fr_pool;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment