Commit 6a24c8fb authored by Fuqian Huang's avatar Fuqian Huang Committed by David S. Miller

hippi: Remove call to memset after pci_alloc_consistent

pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f19
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3a5ee3b3
...@@ -1196,7 +1196,6 @@ static int rr_open(struct net_device *dev) ...@@ -1196,7 +1196,6 @@ static int rr_open(struct net_device *dev)
goto error; goto error;
} }
rrpriv->rx_ctrl_dma = dma_addr; rrpriv->rx_ctrl_dma = dma_addr;
memset(rrpriv->rx_ctrl, 0, 256*sizeof(struct ring_ctrl));
rrpriv->info = pci_alloc_consistent(pdev, sizeof(struct rr_info), rrpriv->info = pci_alloc_consistent(pdev, sizeof(struct rr_info),
&dma_addr); &dma_addr);
...@@ -1205,7 +1204,6 @@ static int rr_open(struct net_device *dev) ...@@ -1205,7 +1204,6 @@ static int rr_open(struct net_device *dev)
goto error; goto error;
} }
rrpriv->info_dma = dma_addr; rrpriv->info_dma = dma_addr;
memset(rrpriv->info, 0, sizeof(struct rr_info));
wmb(); wmb();
spin_lock_irqsave(&rrpriv->lock, flags); spin_lock_irqsave(&rrpriv->lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment