Commit 6a80467a authored by Tom Rix's avatar Tom Rix Committed by Greg Kroah-Hartman

vme: remove unneeded break

A break is not needed if it is preceded by a return or goto
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20201019165112.29091-1-trix@redhat.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b61fe3b5
...@@ -506,7 +506,6 @@ static int tsi148_slave_set(struct vme_slave_resource *image, int enabled, ...@@ -506,7 +506,6 @@ static int tsi148_slave_set(struct vme_slave_resource *image, int enabled,
default: default:
dev_err(tsi148_bridge->parent, "Invalid address space\n"); dev_err(tsi148_bridge->parent, "Invalid address space\n");
return -EINVAL; return -EINVAL;
break;
} }
/* Convert 64-bit variables to 2x 32-bit variables */ /* Convert 64-bit variables to 2x 32-bit variables */
...@@ -995,7 +994,6 @@ static int tsi148_master_set(struct vme_master_resource *image, int enabled, ...@@ -995,7 +994,6 @@ static int tsi148_master_set(struct vme_master_resource *image, int enabled,
dev_err(tsi148_bridge->parent, "Invalid address space\n"); dev_err(tsi148_bridge->parent, "Invalid address space\n");
retval = -EINVAL; retval = -EINVAL;
goto err_aspace; goto err_aspace;
break;
} }
temp_ctl &= ~(3<<4); temp_ctl &= ~(3<<4);
...@@ -1503,7 +1501,6 @@ static int tsi148_dma_set_vme_src_attributes(struct device *dev, __be32 *attr, ...@@ -1503,7 +1501,6 @@ static int tsi148_dma_set_vme_src_attributes(struct device *dev, __be32 *attr,
default: default:
dev_err(dev, "Invalid address space\n"); dev_err(dev, "Invalid address space\n");
return -EINVAL; return -EINVAL;
break;
} }
if (cycle & VME_SUPER) if (cycle & VME_SUPER)
...@@ -1603,7 +1600,6 @@ static int tsi148_dma_set_vme_dest_attributes(struct device *dev, __be32 *attr, ...@@ -1603,7 +1600,6 @@ static int tsi148_dma_set_vme_dest_attributes(struct device *dev, __be32 *attr,
default: default:
dev_err(dev, "Invalid address space\n"); dev_err(dev, "Invalid address space\n");
return -EINVAL; return -EINVAL;
break;
} }
if (cycle & VME_SUPER) if (cycle & VME_SUPER)
...@@ -1701,7 +1697,6 @@ static int tsi148_dma_list_add(struct vme_dma_list *list, ...@@ -1701,7 +1697,6 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
dev_err(tsi148_bridge->parent, "Invalid source type\n"); dev_err(tsi148_bridge->parent, "Invalid source type\n");
retval = -EINVAL; retval = -EINVAL;
goto err_source; goto err_source;
break;
} }
/* Assume last link - this will be over-written by adding another */ /* Assume last link - this will be over-written by adding another */
...@@ -1738,7 +1733,6 @@ static int tsi148_dma_list_add(struct vme_dma_list *list, ...@@ -1738,7 +1733,6 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
dev_err(tsi148_bridge->parent, "Invalid destination type\n"); dev_err(tsi148_bridge->parent, "Invalid destination type\n");
retval = -EINVAL; retval = -EINVAL;
goto err_dest; goto err_dest;
break;
} }
/* Fill out count */ /* Fill out count */
...@@ -1964,7 +1958,6 @@ static int tsi148_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base, ...@@ -1964,7 +1958,6 @@ static int tsi148_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base,
mutex_unlock(&lm->mtx); mutex_unlock(&lm->mtx);
dev_err(tsi148_bridge->parent, "Invalid address space\n"); dev_err(tsi148_bridge->parent, "Invalid address space\n");
return -EINVAL; return -EINVAL;
break;
} }
if (cycle & VME_SUPER) if (cycle & VME_SUPER)
......
...@@ -52,23 +52,18 @@ static struct vme_bridge *find_bridge(struct vme_resource *resource) ...@@ -52,23 +52,18 @@ static struct vme_bridge *find_bridge(struct vme_resource *resource)
case VME_MASTER: case VME_MASTER:
return list_entry(resource->entry, struct vme_master_resource, return list_entry(resource->entry, struct vme_master_resource,
list)->parent; list)->parent;
break;
case VME_SLAVE: case VME_SLAVE:
return list_entry(resource->entry, struct vme_slave_resource, return list_entry(resource->entry, struct vme_slave_resource,
list)->parent; list)->parent;
break;
case VME_DMA: case VME_DMA:
return list_entry(resource->entry, struct vme_dma_resource, return list_entry(resource->entry, struct vme_dma_resource,
list)->parent; list)->parent;
break;
case VME_LM: case VME_LM:
return list_entry(resource->entry, struct vme_lm_resource, return list_entry(resource->entry, struct vme_lm_resource,
list)->parent; list)->parent;
break;
default: default:
printk(KERN_ERR "Unknown resource type\n"); printk(KERN_ERR "Unknown resource type\n");
return NULL; return NULL;
break;
} }
} }
...@@ -179,7 +174,6 @@ size_t vme_get_size(struct vme_resource *resource) ...@@ -179,7 +174,6 @@ size_t vme_get_size(struct vme_resource *resource)
return 0; return 0;
return size; return size;
break;
case VME_SLAVE: case VME_SLAVE:
retval = vme_slave_get(resource, &enabled, &base, &size, retval = vme_slave_get(resource, &enabled, &base, &size,
&buf_base, &aspace, &cycle); &buf_base, &aspace, &cycle);
...@@ -187,14 +181,11 @@ size_t vme_get_size(struct vme_resource *resource) ...@@ -187,14 +181,11 @@ size_t vme_get_size(struct vme_resource *resource)
return 0; return 0;
return size; return size;
break;
case VME_DMA: case VME_DMA:
return 0; return 0;
break;
default: default:
printk(KERN_ERR "Unknown resource type\n"); printk(KERN_ERR "Unknown resource type\n");
return 0; return 0;
break;
} }
} }
EXPORT_SYMBOL(vme_get_size); EXPORT_SYMBOL(vme_get_size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment