Commit 6a93bb7e authored by Kamalesh Babulal's avatar Kamalesh Babulal Committed by Ingo Molnar

objtool: Print top level commands on incorrect usage

Print top-level objtool commands, along with the error on incorrect
command line usage. Objtool command line parser exit's with code 129,
for incorrect usage. Convert the cmd_usage() exit code also, to maintain
consistency across objtool.

After the patch:

  $ ./objtool -j

  Unknown option: -j

  usage: objtool COMMAND [ARGS]

  Commands:
     check   Perform stack metadata validation on an object file
     orc     Generate in-place ORC unwind tables for an object file

  $ echo $?
  129
Signed-off-by: default avatarKamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 2704fbb6
...@@ -70,7 +70,7 @@ static void cmd_usage(void) ...@@ -70,7 +70,7 @@ static void cmd_usage(void)
printf("\n"); printf("\n");
exit(1); exit(129);
} }
static void handle_options(int *argc, const char ***argv) static void handle_options(int *argc, const char ***argv)
...@@ -86,9 +86,7 @@ static void handle_options(int *argc, const char ***argv) ...@@ -86,9 +86,7 @@ static void handle_options(int *argc, const char ***argv)
break; break;
} else { } else {
fprintf(stderr, "Unknown option: %s\n", cmd); fprintf(stderr, "Unknown option: %s\n", cmd);
fprintf(stderr, "\n Usage: %s\n", cmd_usage();
objtool_usage_string);
exit(1);
} }
(*argv)++; (*argv)++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment