Commit 6b3ed785 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown

ASoC: Fix snd_soc_instantiate_card error path

Properly free the resources in the case of snd_card_register failure
and soc_register_ac97_dai_link failure.
Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 0b9a214a
...@@ -1839,18 +1839,20 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card) ...@@ -1839,18 +1839,20 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card)
ret = snd_card_register(card->snd_card); ret = snd_card_register(card->snd_card);
if (ret < 0) { if (ret < 0) {
printk(KERN_ERR "asoc: failed to register soundcard for %s\n", card->name); printk(KERN_ERR "asoc: failed to register soundcard for %s\n", card->name);
goto probe_dai_err; goto probe_aux_dev_err;
} }
#ifdef CONFIG_SND_SOC_AC97_BUS #ifdef CONFIG_SND_SOC_AC97_BUS
/* register any AC97 codecs */ /* register any AC97 codecs */
for (i = 0; i < card->num_rtd; i++) { for (i = 0; i < card->num_rtd; i++) {
ret = soc_register_ac97_dai_link(&card->rtd[i]); ret = soc_register_ac97_dai_link(&card->rtd[i]);
if (ret < 0) { if (ret < 0) {
printk(KERN_ERR "asoc: failed to register AC97 %s\n", card->name); printk(KERN_ERR "asoc: failed to register AC97 %s\n", card->name);
goto probe_dai_err; while (--i >= 0)
} soc_unregister_ac97_dai_link(&card->rtd[i]);
goto probe_aux_dev_err;
} }
}
#endif #endif
card->instantiated = 1; card->instantiated = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment