Commit 6b7e5cad authored by Matthew Wilcox's avatar Matthew Wilcox Committed by Linus Torvalds

mm: remove sysctl_extfrag_handler()

sysctl_extfrag_handler() neglects to propagate the return value from
proc_dointvec_minmax() to its caller.  It's a wrapper that doesn't need
to exist, so just use proc_dointvec_minmax() directly.

Link: http://lkml.kernel.org/r/20190104032557.3056-1-willy@infradead.orgSigned-off-by: default avatarMatthew Wilcox <willy@infradead.org>
Reported-by: default avatarAditya Pakki <pakki001@umn.edu>
Acked-by: default avatarMel Gorman <mgorman@techsingularity.net>
Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a05ef00c
...@@ -88,8 +88,6 @@ extern int sysctl_compact_memory; ...@@ -88,8 +88,6 @@ extern int sysctl_compact_memory;
extern int sysctl_compaction_handler(struct ctl_table *table, int write, extern int sysctl_compaction_handler(struct ctl_table *table, int write,
void __user *buffer, size_t *length, loff_t *ppos); void __user *buffer, size_t *length, loff_t *ppos);
extern int sysctl_extfrag_threshold; extern int sysctl_extfrag_threshold;
extern int sysctl_extfrag_handler(struct ctl_table *table, int write,
void __user *buffer, size_t *length, loff_t *ppos);
extern int sysctl_compact_unevictable_allowed; extern int sysctl_compact_unevictable_allowed;
extern int fragmentation_index(struct zone *zone, unsigned int order); extern int fragmentation_index(struct zone *zone, unsigned int order);
......
...@@ -1460,7 +1460,7 @@ static struct ctl_table vm_table[] = { ...@@ -1460,7 +1460,7 @@ static struct ctl_table vm_table[] = {
.data = &sysctl_extfrag_threshold, .data = &sysctl_extfrag_threshold,
.maxlen = sizeof(int), .maxlen = sizeof(int),
.mode = 0644, .mode = 0644,
.proc_handler = sysctl_extfrag_handler, .proc_handler = proc_dointvec_minmax,
.extra1 = &min_extfrag_threshold, .extra1 = &min_extfrag_threshold,
.extra2 = &max_extfrag_threshold, .extra2 = &max_extfrag_threshold,
}, },
......
...@@ -1876,14 +1876,6 @@ int sysctl_compaction_handler(struct ctl_table *table, int write, ...@@ -1876,14 +1876,6 @@ int sysctl_compaction_handler(struct ctl_table *table, int write,
return 0; return 0;
} }
int sysctl_extfrag_handler(struct ctl_table *table, int write,
void __user *buffer, size_t *length, loff_t *ppos)
{
proc_dointvec_minmax(table, write, buffer, length, ppos);
return 0;
}
#if defined(CONFIG_SYSFS) && defined(CONFIG_NUMA) #if defined(CONFIG_SYSFS) && defined(CONFIG_NUMA)
static ssize_t sysfs_compact_node(struct device *dev, static ssize_t sysfs_compact_node(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment