Commit 6b9fbb07 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mark Brown

ASoC: img-parallel-out: Fix a reference count leak

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200614033344.1814-1-wu000273@umn.eduSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent c4c59b95
...@@ -163,8 +163,10 @@ static int img_prl_out_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) ...@@ -163,8 +163,10 @@ static int img_prl_out_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
} }
ret = pm_runtime_get_sync(prl->dev); ret = pm_runtime_get_sync(prl->dev);
if (ret < 0) if (ret < 0) {
pm_runtime_put_noidle(prl->dev);
return ret; return ret;
}
reg = img_prl_out_readl(prl, IMG_PRL_OUT_CTL); reg = img_prl_out_readl(prl, IMG_PRL_OUT_CTL);
reg = (reg & ~IMG_PRL_OUT_CTL_EDGE_MASK) | control_set; reg = (reg & ~IMG_PRL_OUT_CTL_EDGE_MASK) | control_set;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment