Commit 6c906542 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

atm: lanai: use %p to format kernel addresses instead of %x

Don't use %x and casting to print out a kernel address, instead use %p
and remove the casting.  Cleans up smatch warnings:

drivers/atm/lanai.c:1589 service_buffer_allocate() warn: argument 2 to
%08lX specifier is cast from pointer
drivers/atm/lanai.c:2221 lanai_dev_open() warn: argument 4 to %lx
specifier is cast from pointer
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4a5def7f
...@@ -1586,8 +1586,8 @@ static int service_buffer_allocate(struct lanai_dev *lanai) ...@@ -1586,8 +1586,8 @@ static int service_buffer_allocate(struct lanai_dev *lanai)
lanai->pci); lanai->pci);
if (unlikely(lanai->service.start == NULL)) if (unlikely(lanai->service.start == NULL))
return -ENOMEM; return -ENOMEM;
DPRINTK("allocated service buffer at 0x%08lX, size %zu(%d)\n", DPRINTK("allocated service buffer at %p, size %zu(%d)\n",
(unsigned long) lanai->service.start, lanai->service.start,
lanai_buf_size(&lanai->service), lanai_buf_size(&lanai->service),
lanai_buf_size_cardorder(&lanai->service)); lanai_buf_size_cardorder(&lanai->service));
/* Clear ServWrite register to be safe */ /* Clear ServWrite register to be safe */
...@@ -2220,9 +2220,9 @@ static int lanai_dev_open(struct atm_dev *atmdev) ...@@ -2220,9 +2220,9 @@ static int lanai_dev_open(struct atm_dev *atmdev)
#endif #endif
memcpy(atmdev->esi, eeprom_mac(lanai), ESI_LEN); memcpy(atmdev->esi, eeprom_mac(lanai), ESI_LEN);
lanai_timed_poll_start(lanai); lanai_timed_poll_start(lanai);
printk(KERN_NOTICE DEV_LABEL "(itf %d): rev.%d, base=0x%lx, irq=%u " printk(KERN_NOTICE DEV_LABEL "(itf %d): rev.%d, base=%p, irq=%u "
"(%pMF)\n", lanai->number, (int) lanai->pci->revision, "(%pMF)\n", lanai->number, (int) lanai->pci->revision,
(unsigned long) lanai->base, lanai->pci->irq, atmdev->esi); lanai->base, lanai->pci->irq, atmdev->esi);
printk(KERN_NOTICE DEV_LABEL "(itf %d): LANAI%s, serialno=%u(0x%X), " printk(KERN_NOTICE DEV_LABEL "(itf %d): LANAI%s, serialno=%u(0x%X), "
"board_rev=%d\n", lanai->number, "board_rev=%d\n", lanai->number,
lanai->type==lanai2 ? "2" : "HB", (unsigned int) lanai->serialno, lanai->type==lanai2 ? "2" : "HB", (unsigned int) lanai->serialno,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment