Commit 6d00376a authored by Dan Carpenter's avatar Dan Carpenter Committed by Herbert Xu

crypto: caam - ARRAY_SIZE() vs sizeof()

ARRAY_SIZE() was intended here instead of sizeof().  sizeof() is four
times larger than ARRAY_SIZE().  outstr is normally 256 chars so 
printing garbage to it could overfill the buffer and corrupt memory.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarKim Phillips <kim.phillips@freescale.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent cdc712d8
...@@ -73,7 +73,7 @@ static void report_ccb_status(u32 status, char *outstr) ...@@ -73,7 +73,7 @@ static void report_ccb_status(u32 status, char *outstr)
report_jump_idx(status, outstr); report_jump_idx(status, outstr);
if (cha_id < sizeof(cha_id_list)) { if (cha_id < ARRAY_SIZE(cha_id_list)) {
SPRINTFCAT(outstr, "%s: ", cha_id_list[cha_id], SPRINTFCAT(outstr, "%s: ", cha_id_list[cha_id],
strlen(cha_id_list[cha_id])); strlen(cha_id_list[cha_id]));
} else { } else {
...@@ -81,7 +81,7 @@ static void report_ccb_status(u32 status, char *outstr) ...@@ -81,7 +81,7 @@ static void report_ccb_status(u32 status, char *outstr)
cha_id, sizeof("ff")); cha_id, sizeof("ff"));
} }
if (err_id < sizeof(err_id_list)) { if (err_id < ARRAY_SIZE(err_id_list)) {
SPRINTFCAT(outstr, "%s", err_id_list[err_id], SPRINTFCAT(outstr, "%s", err_id_list[err_id],
strlen(err_id_list[err_id])); strlen(err_id_list[err_id]));
} else { } else {
...@@ -198,11 +198,11 @@ static void report_deco_status(u32 status, char *outstr) ...@@ -198,11 +198,11 @@ static void report_deco_status(u32 status, char *outstr)
report_jump_idx(status, outstr); report_jump_idx(status, outstr);
for (i = 0; i < sizeof(desc_error_list); i++) for (i = 0; i < ARRAY_SIZE(desc_error_list); i++)
if (desc_error_list[i].value == desc_error) if (desc_error_list[i].value == desc_error)
break; break;
if (i != sizeof(desc_error_list) && desc_error_list[i].error_text) { if (i != ARRAY_SIZE(desc_error_list) && desc_error_list[i].error_text) {
SPRINTFCAT(outstr, "%s", desc_error_list[i].error_text, SPRINTFCAT(outstr, "%s", desc_error_list[i].error_text,
strlen(desc_error_list[i].error_text)); strlen(desc_error_list[i].error_text));
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment