Commit 6dae40ae authored by Linus Torvalds's avatar Linus Torvalds

fbmem: fix horribly incorrect placement of __maybe_unused

Commit b9d79e4c ("fbmem: Mark proc_fb_seq_ops as __maybe_unused")
places the '__maybe_unused' in an entirely incorrect location between
the "struct" keyword and the structure name.

It's a wonder that gcc accepts that silently, but clang quite reasonably
warns about it:

    drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute declaration must precede definition [-Wignored-attributes]
    static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
                        ^

Fix it.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent efc58a96
...@@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v) ...@@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v)
return 0; return 0;
} }
static const struct __maybe_unused seq_operations proc_fb_seq_ops = { static const struct seq_operations __maybe_unused proc_fb_seq_ops = {
.start = fb_seq_start, .start = fb_seq_start,
.next = fb_seq_next, .next = fb_seq_next,
.stop = fb_seq_stop, .stop = fb_seq_stop,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment