Commit 6e641c94 authored by Stefan Weil's avatar Stefan Weil Committed by Jiri Kosina

Documentation: Fix size parameter for snprintf

cppcheck reports this error:

Documentation/laptops/hpfall.c:33]: (error)
 Dangerous usage of 'devname' (strncpy doesn't always 0-terminate it)

The terminating '\0' is needed for the global char array unload_heads_path,
so never write the last array entry (which is initially '\0').
Signed-off-by: default avatarStefan Weil <sw@weilnetz.de>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent e0ea0414
...@@ -29,7 +29,7 @@ int set_unload_heads_path(char *device) ...@@ -29,7 +29,7 @@ int set_unload_heads_path(char *device)
return -EINVAL; return -EINVAL;
strncpy(devname, device + 5, sizeof(devname)); strncpy(devname, device + 5, sizeof(devname));
snprintf(unload_heads_path, sizeof(unload_heads_path), snprintf(unload_heads_path, sizeof(unload_heads_path) - 1,
"/sys/block/%s/device/unload_heads", devname); "/sys/block/%s/device/unload_heads", devname);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment