Commit 6e8a914a authored by Takashi Iwai's avatar Takashi Iwai

ALSA: line6: Perform sanity check for each URB creation

LINE6 drivers create stream URBs with a fixed pipe without checking
its validity, and this may lead to a kernel WARNING at the submission
when a malformed USB descriptor is passed.

For avoiding the kernel warning, perform the similar sanity checks for
each pipe type at creating a URB.

Reported-by: syzbot+c190f6858a04ea7fbc52@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/s5hv9iv4hq8.wl-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f79a732a
...@@ -286,6 +286,8 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm) ...@@ -286,6 +286,8 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm)
urb->interval = LINE6_ISO_INTERVAL; urb->interval = LINE6_ISO_INTERVAL;
urb->error_count = 0; urb->error_count = 0;
urb->complete = audio_in_callback; urb->complete = audio_in_callback;
if (usb_urb_ep_type_check(urb))
return -EINVAL;
} }
return 0; return 0;
......
...@@ -431,6 +431,8 @@ int line6_create_audio_out_urbs(struct snd_line6_pcm *line6pcm) ...@@ -431,6 +431,8 @@ int line6_create_audio_out_urbs(struct snd_line6_pcm *line6pcm)
urb->interval = LINE6_ISO_INTERVAL; urb->interval = LINE6_ISO_INTERVAL;
urb->error_count = 0; urb->error_count = 0;
urb->complete = audio_out_callback; urb->complete = audio_out_callback;
if (usb_urb_ep_type_check(urb))
return -EINVAL;
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment