Commit 6ebb827f authored by YueHaibing's avatar YueHaibing Committed by Vinod Koul

dmaengine: sun4i: use 'linear_mode' in sun4i_dma_prep_dma_cyclic

drivers/dma/sun4i-dma.c: In function sun4i_dma_prep_dma_cyclic:
drivers/dma/sun4i-dma.c:672:24: warning:
 variable linear_mode set but not used [-Wunused-but-set-variable]

commit ffc079a4 ("dmaengine: sun4i: Add support for cyclic requests with dedicated DMA")
involved this, explicitly using the value makes the code more readable.
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20200207024445.44600-1-yuehaibing@huawei.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5ca3364a
...@@ -698,10 +698,12 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len, ...@@ -698,10 +698,12 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len,
endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(vchan->endpoint) | endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(vchan->endpoint) |
SUN4I_DMA_CFG_DST_ADDR_MODE(io_mode) | SUN4I_DMA_CFG_DST_ADDR_MODE(io_mode) |
SUN4I_DMA_CFG_SRC_DRQ_TYPE(ram_type); SUN4I_DMA_CFG_SRC_DRQ_TYPE(ram_type);
SUN4I_DMA_CFG_SRC_ADDR_MODE(linear_mode);
} else { } else {
src = sconfig->src_addr; src = sconfig->src_addr;
dest = buf; dest = buf;
endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(ram_type) | endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(ram_type) |
SUN4I_DMA_CFG_DST_ADDR_MODE(linear_mode) |
SUN4I_DMA_CFG_SRC_DRQ_TYPE(vchan->endpoint) | SUN4I_DMA_CFG_SRC_DRQ_TYPE(vchan->endpoint) |
SUN4I_DMA_CFG_SRC_ADDR_MODE(io_mode); SUN4I_DMA_CFG_SRC_ADDR_MODE(io_mode);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment