Commit 6fbc7692 authored by Mark Salyzyn's avatar Mark Salyzyn Committed by James Bottomley

[SCSI] pm8001: missing break statements

Code Inspection: found two missing break directives. First one will
result in not retrying an a task that report
IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY, the second will result in cosmetic
debug printk conflicting statement stutter. Because checkpatch.pl came
up with a warning regarding unnecessary space before a newline on one of
the fragments associated with the diff context, I took the liberty of
fixing all the cases of this issue in the pair of files touched by this
defect. These cosmetic changes hide the break changes :-(

To help focus, break changes are in pm8001_hwi.c fragment line 1649 for
the IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY case statement and pm8001_sas.c
line 1000 deals with the conflicting debug print stutter.
Signed-off-by: default avatarMark Salyzyn <mark_salyzyn@us.xyratex.com>
Acked-by: default avatarJack Wang <jack_wang@usish.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent b90b378a
This diff is collapsed.
...@@ -609,7 +609,7 @@ static int pm8001_dev_found_notify(struct domain_device *dev) ...@@ -609,7 +609,7 @@ static int pm8001_dev_found_notify(struct domain_device *dev)
flag = 1; /* directly sata*/ flag = 1; /* directly sata*/
} }
} /*register this device to HBA*/ } /*register this device to HBA*/
PM8001_DISC_DBG(pm8001_ha, pm8001_printk("Found device \n")); PM8001_DISC_DBG(pm8001_ha, pm8001_printk("Found device\n"));
PM8001_CHIP_DISP->reg_dev_req(pm8001_ha, pm8001_device, flag); PM8001_CHIP_DISP->reg_dev_req(pm8001_ha, pm8001_device, flag);
spin_unlock_irqrestore(&pm8001_ha->lock, flags); spin_unlock_irqrestore(&pm8001_ha->lock, flags);
wait_for_completion(&completion); wait_for_completion(&completion);
...@@ -958,13 +958,14 @@ int pm8001_query_task(struct sas_task *task) ...@@ -958,13 +958,14 @@ int pm8001_query_task(struct sas_task *task)
/* The task is still in Lun, release it then */ /* The task is still in Lun, release it then */
case TMF_RESP_FUNC_SUCC: case TMF_RESP_FUNC_SUCC:
PM8001_EH_DBG(pm8001_ha, PM8001_EH_DBG(pm8001_ha,
pm8001_printk("The task is still in Lun \n")); pm8001_printk("The task is still in Lun\n"));
break;
/* The task is not in Lun or failed, reset the phy */ /* The task is not in Lun or failed, reset the phy */
case TMF_RESP_FUNC_FAILED: case TMF_RESP_FUNC_FAILED:
case TMF_RESP_FUNC_COMPLETE: case TMF_RESP_FUNC_COMPLETE:
PM8001_EH_DBG(pm8001_ha, PM8001_EH_DBG(pm8001_ha,
pm8001_printk("The task is not in Lun or failed," pm8001_printk("The task is not in Lun or failed,"
" reset the phy \n")); " reset the phy\n"));
break; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment