Commit 709b9326 authored by David S. Miller's avatar David S. Miller

Revert "bridge: Use hlist_for_each_entry_rcu() in br_multicast_add_router()"

This reverts commit ff65e827.

As explained by Stephen Hemminger, the traversal doesn't require
RCU handling as we hold a lock.

The list addition et al. calls, on the other hand, do.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2a1f8794
...@@ -1045,7 +1045,7 @@ static void br_multicast_add_router(struct net_bridge *br, ...@@ -1045,7 +1045,7 @@ static void br_multicast_add_router(struct net_bridge *br,
struct net_bridge_port *p; struct net_bridge_port *p;
struct hlist_node *n, *last = NULL; struct hlist_node *n, *last = NULL;
hlist_for_each_entry_rcu(p, n, &br->router_list, rlist) { hlist_for_each_entry(p, n, &br->router_list, rlist) {
if ((unsigned long) port >= (unsigned long) p) { if ((unsigned long) port >= (unsigned long) p) {
hlist_add_before_rcu(n, &port->rlist); hlist_add_before_rcu(n, &port->rlist);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment