Commit 70a2783c authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva

video: fbdev: omapfb_main: Mark expected switch fall-throughs

Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: omap1_defconfig arm):

drivers/watchdog/wdt285.c:170:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/watchdog/ar7_wdt.c:237:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
parent 40ad2de3
...@@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane, ...@@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane,
return 0; return 0;
case 12: case 12:
var->bits_per_pixel = 16; var->bits_per_pixel = 16;
/* fall through */
case 16: case 16:
if (plane->fbdev->panel->bpp == 12) if (plane->fbdev->panel->bpp == 12)
plane->color_mode = OMAPFB_COLOR_RGB444; plane->color_mode = OMAPFB_COLOR_RGB444;
...@@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state) ...@@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)
case OMAPFB_ACTIVE: case OMAPFB_ACTIVE:
for (i = 0; i < fbdev->mem_desc.region_cnt; i++) for (i = 0; i < fbdev->mem_desc.region_cnt; i++)
unregister_framebuffer(fbdev->fb_info[i]); unregister_framebuffer(fbdev->fb_info[i]);
/* fall through */
case 7: case 7:
omapfb_unregister_sysfs(fbdev); omapfb_unregister_sysfs(fbdev);
/* fall through */
case 6: case 6:
if (fbdev->panel->disable) if (fbdev->panel->disable)
fbdev->panel->disable(fbdev->panel); fbdev->panel->disable(fbdev->panel);
/* fall through */
case 5: case 5:
omapfb_set_update_mode(fbdev, OMAPFB_UPDATE_DISABLED); omapfb_set_update_mode(fbdev, OMAPFB_UPDATE_DISABLED);
/* fall through */
case 4: case 4:
planes_cleanup(fbdev); planes_cleanup(fbdev);
/* fall through */
case 3: case 3:
ctrl_cleanup(fbdev); ctrl_cleanup(fbdev);
/* fall through */
case 2: case 2:
if (fbdev->panel->cleanup) if (fbdev->panel->cleanup)
fbdev->panel->cleanup(fbdev->panel); fbdev->panel->cleanup(fbdev->panel);
/* fall through */
case 1: case 1:
dev_set_drvdata(fbdev->dev, NULL); dev_set_drvdata(fbdev->dev, NULL);
kfree(fbdev); kfree(fbdev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment