Commit 71fb2788 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman

[PATCH] catc: GFP_KERNEL in interrupt or with spinlocks held

bad usage of mem_flags in catc.
parent 2beb6488
...@@ -278,7 +278,7 @@ static void catc_rx_done(struct urb *urb) ...@@ -278,7 +278,7 @@ static void catc_rx_done(struct urb *urb)
atomic_dec(&catc->recq_sz); atomic_dec(&catc->recq_sz);
dbg("getting extra packet"); dbg("getting extra packet");
urb->dev = catc->usbdev; urb->dev = catc->usbdev;
if ((status = usb_submit_urb(urb, GFP_KERNEL)) < 0) { if ((status = usb_submit_urb(urb, GFP_ATOMIC)) < 0) {
dbg("submit(rx_urb) status %d", status); dbg("submit(rx_urb) status %d", status);
} }
} else { } else {
...@@ -329,7 +329,7 @@ static void catc_irq_done(struct urb *urb) ...@@ -329,7 +329,7 @@ static void catc_irq_done(struct urb *urb)
atomic_inc(&catc->recq_sz); atomic_inc(&catc->recq_sz);
} else { } else {
catc->rx_urb->dev = catc->usbdev; catc->rx_urb->dev = catc->usbdev;
if ((status = usb_submit_urb(catc->rx_urb, GFP_KERNEL)) < 0) { if ((status = usb_submit_urb(catc->rx_urb, GFP_ATOMIC)) < 0) {
err("submit(rx_urb) status %d", status); err("submit(rx_urb) status %d", status);
} }
} }
...@@ -351,7 +351,7 @@ static void catc_tx_run(struct catc *catc) ...@@ -351,7 +351,7 @@ static void catc_tx_run(struct catc *catc)
catc->tx_urb->transfer_buffer = catc->tx_buf[catc->tx_idx]; catc->tx_urb->transfer_buffer = catc->tx_buf[catc->tx_idx];
catc->tx_urb->dev = catc->usbdev; catc->tx_urb->dev = catc->usbdev;
if ((status = usb_submit_urb(catc->tx_urb, GFP_KERNEL)) < 0) if ((status = usb_submit_urb(catc->tx_urb, GFP_ATOMIC)) < 0)
err("submit(tx_urb), status %d", status); err("submit(tx_urb), status %d", status);
catc->tx_idx = !catc->tx_idx; catc->tx_idx = !catc->tx_idx;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment