Commit 722d9484 authored by Jamie Hill-Daniel's avatar Jamie Hill-Daniel Committed by Linus Torvalds

vfs: fs_context: fix up param length parsing in legacy_parse_param

The "PAGE_SIZE - 2 - size" calculation in legacy_parse_param() is an
unsigned type so a large value of "size" results in a high positive
value instead of a negative value as expected.  Fix this by getting rid
of the subtraction.
Signed-off-by: default avatarJamie Hill-Daniel <jamie@hill-daniel.co.uk>
Signed-off-by: default avatarWilliam Liu <willsroot@protonmail.com>
Tested-by: default avatarSalvatore Bonaccorso <carnil@debian.org>
Tested-by: default avatarThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Acked-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8357f6fb
...@@ -548,7 +548,7 @@ static int legacy_parse_param(struct fs_context *fc, struct fs_parameter *param) ...@@ -548,7 +548,7 @@ static int legacy_parse_param(struct fs_context *fc, struct fs_parameter *param)
param->key); param->key);
} }
if (len > PAGE_SIZE - 2 - size) if (size + len + 2 > PAGE_SIZE)
return invalf(fc, "VFS: Legacy: Cumulative options too large"); return invalf(fc, "VFS: Legacy: Cumulative options too large");
if (strchr(param->key, ',') || if (strchr(param->key, ',') ||
(param->type == fs_value_is_string && (param->type == fs_value_is_string &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment