Commit 7418ee4c authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso

netfilter: nf_tables: prefer skb_ensure_writable

.. so skb_make_writable can be removed.
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 3862c6a9
...@@ -156,7 +156,8 @@ static void nft_exthdr_tcp_set_eval(const struct nft_expr *expr, ...@@ -156,7 +156,8 @@ static void nft_exthdr_tcp_set_eval(const struct nft_expr *expr,
if (i + optl > tcphdr_len || priv->len + priv->offset > optl) if (i + optl > tcphdr_len || priv->len + priv->offset > optl)
return; return;
if (!skb_make_writable(pkt->skb, pkt->xt.thoff + i + priv->len)) if (skb_ensure_writable(pkt->skb,
pkt->xt.thoff + i + priv->len))
return; return;
tcph = nft_tcp_header_pointer(pkt, sizeof(buff), buff, tcph = nft_tcp_header_pointer(pkt, sizeof(buff), buff,
......
...@@ -243,7 +243,7 @@ static int nft_payload_l4csum_update(const struct nft_pktinfo *pkt, ...@@ -243,7 +243,7 @@ static int nft_payload_l4csum_update(const struct nft_pktinfo *pkt,
tsum)); tsum));
} }
if (!skb_make_writable(skb, l4csum_offset + sizeof(sum)) || if (skb_ensure_writable(skb, l4csum_offset + sizeof(sum)) ||
skb_store_bits(skb, l4csum_offset, &sum, sizeof(sum)) < 0) skb_store_bits(skb, l4csum_offset, &sum, sizeof(sum)) < 0)
return -1; return -1;
...@@ -259,7 +259,7 @@ static int nft_payload_csum_inet(struct sk_buff *skb, const u32 *src, ...@@ -259,7 +259,7 @@ static int nft_payload_csum_inet(struct sk_buff *skb, const u32 *src,
return -1; return -1;
nft_csum_replace(&sum, fsum, tsum); nft_csum_replace(&sum, fsum, tsum);
if (!skb_make_writable(skb, csum_offset + sizeof(sum)) || if (skb_ensure_writable(skb, csum_offset + sizeof(sum)) ||
skb_store_bits(skb, csum_offset, &sum, sizeof(sum)) < 0) skb_store_bits(skb, csum_offset, &sum, sizeof(sum)) < 0)
return -1; return -1;
...@@ -312,7 +312,7 @@ static void nft_payload_set_eval(const struct nft_expr *expr, ...@@ -312,7 +312,7 @@ static void nft_payload_set_eval(const struct nft_expr *expr,
goto err; goto err;
} }
if (!skb_make_writable(skb, max(offset + priv->len, 0)) || if (skb_ensure_writable(skb, max(offset + priv->len, 0)) ||
skb_store_bits(skb, offset, src, priv->len) < 0) skb_store_bits(skb, offset, src, priv->len) < 0)
goto err; goto err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment