Commit 74b643da authored by Stefan Achatz's avatar Stefan Achatz Committed by Jiri Kosina

HID: roccat: Fix NULL pointer dereference when unloading module

Class was destroyed before starting the unregistering driver chain.
Disconnecting a device from roccat chardev in this process then
raised a NULL pointer dereference.
Fixed this by destroying class after unregistering driver.
Signed-off-by: default avatarStefan Achatz <erazor_de@users.sourceforge.net>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 8211e460
......@@ -438,8 +438,8 @@ static int __init arvo_init(void)
static void __exit arvo_exit(void)
{
class_destroy(arvo_class);
hid_unregister_driver(&arvo_driver);
class_destroy(arvo_class);
}
module_init(arvo_init);
......
......@@ -844,8 +844,8 @@ static int __init kone_init(void)
static void __exit kone_exit(void)
{
class_destroy(kone_class);
hid_unregister_driver(&kone_driver);
class_destroy(kone_class);
}
module_init(kone_init);
......
......@@ -774,8 +774,8 @@ static int __init koneplus_init(void)
static void __exit koneplus_exit(void)
{
class_destroy(koneplus_class);
hid_unregister_driver(&koneplus_driver);
class_destroy(koneplus_class);
}
module_init(koneplus_init);
......
......@@ -703,8 +703,8 @@ static int __init kovaplus_init(void)
static void __exit kovaplus_exit(void)
{
class_destroy(kovaplus_class);
hid_unregister_driver(&kovaplus_driver);
class_destroy(kovaplus_class);
}
module_init(kovaplus_init);
......
......@@ -685,8 +685,8 @@ static int __init pyra_init(void)
static void __exit pyra_exit(void)
{
class_destroy(pyra_class);
hid_unregister_driver(&pyra_driver);
class_destroy(pyra_class);
}
module_init(pyra_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment