Commit 756e21a0 authored by Arthur Othieno's avatar Arthur Othieno Committed by Linus Torvalds

[PATCH] matroxfb: simply return what i2c_add_driver() does

insmod will tell us when the module failed to load.  We do no further
processing on the return from i2c_add_driver(), so just return what
i2c_add_driver() did, instead of storing it.

Add __init/__exit annotations while we're at it.
Signed-off-by: default avatarArthur Othieno <apgo@patchbomb.org>
Acked-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarPetr Vandrovec <petr@vandrovec.name>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent fc4effc7
...@@ -1297,20 +1297,13 @@ static struct i2c_driver maven_driver={ ...@@ -1297,20 +1297,13 @@ static struct i2c_driver maven_driver={
.detach_client = maven_detach_client, .detach_client = maven_detach_client,
}; };
/* ************************** */ static int __init matroxfb_maven_init(void)
{
static int matroxfb_maven_init(void) { return i2c_add_driver(&maven_driver);
int err;
err = i2c_add_driver(&maven_driver);
if (err) {
printk(KERN_ERR "maven: Maven driver failed to register (%d).\n", err);
return err;
}
return 0;
} }
static void matroxfb_maven_exit(void) { static void __exit matroxfb_maven_exit(void)
{
i2c_del_driver(&maven_driver); i2c_del_driver(&maven_driver);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment