Commit 759af9b8 authored by Ajay Singh's avatar Ajay Singh Committed by Greg Kroah-Hartman

staging: wilc1000: remove use of MAX_NUN_INT_THRPT_ENH2 macro

Make use of MAX_NUM_INT existing macro to handle the maximum supported
interrupts count and removed MAX_NUN_INT_THRPT_ENH2 macro.
Signed-off-by: default avatarAjay Singh <ajay.kathat@microchip.com>
Link: https://lore.kernel.org/r/20200214172250.13026-3-ajay.kathat@microchip.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 38f193df
...@@ -27,8 +27,6 @@ struct wilc_sdio { ...@@ -27,8 +27,6 @@ struct wilc_sdio {
bool irq_gpio; bool irq_gpio;
u32 block_size; u32 block_size;
int nint; int nint;
/* Max num interrupts allowed in registers 0xf7, 0xf8 */
#define MAX_NUN_INT_THRPT_ENH2 (5)
int has_thrpt_enh3; int has_thrpt_enh3;
}; };
...@@ -818,8 +816,6 @@ static int wilc_sdio_read_int(struct wilc *wilc, u32 *int_status) ...@@ -818,8 +816,6 @@ static int wilc_sdio_read_int(struct wilc *wilc, u32 *int_status)
tmp |= INT_3; tmp |= INT_3;
if (cmd.data & BIT(5)) if (cmd.data & BIT(5))
tmp |= INT_4; tmp |= INT_4;
if (cmd.data & BIT(6))
tmp |= INT_5;
for (i = sdio_priv->nint; i < MAX_NUM_INT; i++) { for (i = sdio_priv->nint; i < MAX_NUM_INT; i++) {
if ((tmp >> (IRG_FLAGS_OFFSET + i)) & 0x1) { if ((tmp >> (IRG_FLAGS_OFFSET + i)) & 0x1) {
dev_err(&func->dev, dev_err(&func->dev,
...@@ -854,16 +850,11 @@ static int wilc_sdio_clear_int_ext(struct wilc *wilc, u32 val) ...@@ -854,16 +850,11 @@ static int wilc_sdio_clear_int_ext(struct wilc *wilc, u32 val)
int vmm_ctl; int vmm_ctl;
if (sdio_priv->has_thrpt_enh3) { if (sdio_priv->has_thrpt_enh3) {
u32 reg; u32 reg = 0;
if (sdio_priv->irq_gpio) { if (sdio_priv->irq_gpio)
u32 flags; reg = val & (BIT(MAX_NUM_INT) - 1);
flags = val & (BIT(MAX_NUN_INT_THRPT_ENH2) - 1);
reg = flags;
} else {
reg = 0;
}
/* select VMM table 0 */ /* select VMM table 0 */
if (val & SEL_VMM_TBL0) if (val & SEL_VMM_TBL0)
reg |= BIT(5); reg |= BIT(5);
...@@ -975,11 +966,6 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint) ...@@ -975,11 +966,6 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int nint)
dev_err(&func->dev, "Too many interrupts (%d)...\n", nint); dev_err(&func->dev, "Too many interrupts (%d)...\n", nint);
return -EINVAL; return -EINVAL;
} }
if (nint > MAX_NUN_INT_THRPT_ENH2) {
dev_err(&func->dev,
"Cannot support more than 5 interrupts when has_thrpt_enh2=1.\n");
return -EINVAL;
}
sdio_priv->nint = nint; sdio_priv->nint = nint;
......
...@@ -175,7 +175,7 @@ ...@@ -175,7 +175,7 @@
#define INT_3 BIT(IRG_FLAGS_OFFSET + 3) #define INT_3 BIT(IRG_FLAGS_OFFSET + 3)
#define INT_4 BIT(IRG_FLAGS_OFFSET + 4) #define INT_4 BIT(IRG_FLAGS_OFFSET + 4)
#define INT_5 BIT(IRG_FLAGS_OFFSET + 5) #define INT_5 BIT(IRG_FLAGS_OFFSET + 5)
#define MAX_NUM_INT 6 #define MAX_NUM_INT 5
/*******************************************/ /*******************************************/
/* E0 and later Interrupt flags. */ /* E0 and later Interrupt flags. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment