Commit 75b58cf5 authored by Klaus Kudielka's avatar Klaus Kudielka Committed by Gregory CLEMENT

Revert "ARM: dts: armada-38x: Fix compatible string for gpios"

This reverts commit c4de4667, which causes
a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work,
ending up in the DSA switch being non-functional.

The blamed commit is incorrect in the first place:
If compatible = "marvell,armadaxp-gpio", the second (address, size) pair
of the reg property must to point to the per-CPU interrupt registers
<0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers
<0x181c0 0x08> / <0x181c8 0x08>.

But even fixing that leaves the GPIO interrupts broken on the Omnia.

Furthermore:
Commit 5f79c651 explains very well, why the gpio-mvebu driver does not
work reliably with per-CPU interrupts.
Commit 988c8c0c deprecates compatible = marvell,armadaxp-gpio for this
reason.

Fixes: c4de4667 ("ARM: dts: armada-38x: Fix compatible string for gpios")
Reported-by: default avatarKlaus Kudielka <klaus.kudielka@gmail.com>
Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@gmail.com/Signed-off-by: default avatarKlaus Kudielka <klaus.kudielka@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
parent 1b929c02
...@@ -304,7 +304,7 @@ spdif_pins: spdif-pins { ...@@ -304,7 +304,7 @@ spdif_pins: spdif-pins {
}; };
gpio0: gpio@18100 { gpio0: gpio@18100 {
compatible = "marvell,armadaxp-gpio", compatible = "marvell,armada-370-gpio",
"marvell,orion-gpio"; "marvell,orion-gpio";
reg = <0x18100 0x40>, <0x181c0 0x08>; reg = <0x18100 0x40>, <0x181c0 0x08>;
reg-names = "gpio", "pwm"; reg-names = "gpio", "pwm";
...@@ -323,7 +323,7 @@ gpio0: gpio@18100 { ...@@ -323,7 +323,7 @@ gpio0: gpio@18100 {
}; };
gpio1: gpio@18140 { gpio1: gpio@18140 {
compatible = "marvell,armadaxp-gpio", compatible = "marvell,armada-370-gpio",
"marvell,orion-gpio"; "marvell,orion-gpio";
reg = <0x18140 0x40>, <0x181c8 0x08>; reg = <0x18140 0x40>, <0x181c8 0x08>;
reg-names = "gpio", "pwm"; reg-names = "gpio", "pwm";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment