Commit 76e55d93 authored by Mario Limonciello's avatar Mario Limonciello Committed by Linus Walleij

pinctrl: amd: Pick some different unicode symbols

Feedback from Kent had showed some better selections for symbols to
use for pinctrl-amd debugfs output.  Adopt some of those instead.

Fixes: e8129a07 ("pinctrl: amd: Use unicode for debugfs output")
Suggested-by: default avatarKent Gibson <warthog618@gmail.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20220823230753.14799-1-mario.limonciello@amd.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent bbe2a5d8
...@@ -246,7 +246,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) ...@@ -246,7 +246,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
} }
seq_printf(s, "GPIO bank%d\n", bank); seq_printf(s, "GPIO bank%d\n", bank);
for (; i < pin_num; i++) { for (; i < pin_num; i++) {
seq_printf(s, "📌%d\t", i); seq_printf(s, "#%d\t", i);
raw_spin_lock_irqsave(&gpio_dev->lock, flags); raw_spin_lock_irqsave(&gpio_dev->lock, flags);
pin_reg = readl(gpio_dev->base + i * 4); pin_reg = readl(gpio_dev->base + i * 4);
raw_spin_unlock_irqrestore(&gpio_dev->lock, flags); raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
...@@ -278,32 +278,32 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) ...@@ -278,32 +278,32 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
} }
if (pin_reg & BIT(INTERRUPT_MASK_OFF)) if (pin_reg & BIT(INTERRUPT_MASK_OFF))
interrupt_mask = "-"; interrupt_mask = "😛";
else else
interrupt_mask = "+"; interrupt_mask = "😷";
seq_printf(s, "int %s (🎭 %s)| active-%s| %s-🔫| ", seq_printf(s, "int %s (%s)| active-%s| %s-⚡| ",
interrupt_enable, interrupt_enable,
interrupt_mask, interrupt_mask,
active_level, active_level,
level_trig); level_trig);
if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3)) if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3))
wake_cntrl0 = "+"; wake_cntrl0 = "";
else else
wake_cntrl0 = "∅"; wake_cntrl0 = " ∅";
seq_printf(s, "S0i3 🌅 %s| ", wake_cntrl0); seq_printf(s, "S0i3 %s| ", wake_cntrl0);
if (pin_reg & BIT(WAKE_CNTRL_OFF_S3)) if (pin_reg & BIT(WAKE_CNTRL_OFF_S3))
wake_cntrl1 = "+"; wake_cntrl1 = "";
else else
wake_cntrl1 = "∅"; wake_cntrl1 = " ∅";
seq_printf(s, "S3 🌅 %s| ", wake_cntrl1); seq_printf(s, "S3 %s| ", wake_cntrl1);
if (pin_reg & BIT(WAKE_CNTRL_OFF_S4)) if (pin_reg & BIT(WAKE_CNTRL_OFF_S4))
wake_cntrl2 = "+"; wake_cntrl2 = "";
else else
wake_cntrl2 = "∅"; wake_cntrl2 = " ∅";
seq_printf(s, "S4/S5 🌅 %s| ", wake_cntrl2); seq_printf(s, "S4/S5 %s| ", wake_cntrl2);
if (pin_reg & BIT(PULL_UP_ENABLE_OFF)) { if (pin_reg & BIT(PULL_UP_ENABLE_OFF)) {
pull_up_enable = "+"; pull_up_enable = "+";
...@@ -367,7 +367,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) ...@@ -367,7 +367,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
debounce_enable = " ∅"; debounce_enable = " ∅";
} }
snprintf(debounce_value, sizeof(debounce_value), "%u", time * unit); snprintf(debounce_value, sizeof(debounce_value), "%u", time * unit);
seq_printf(s, "debounce %s ( %sus)| ", debounce_enable, debounce_value); seq_printf(s, "debounce %s (🕑 %sus)| ", debounce_enable, debounce_value);
seq_printf(s, " 0x%x\n", pin_reg); seq_printf(s, " 0x%x\n", pin_reg);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment