Commit 76f2c491 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron

iio: frequency: admv1013: Benefit from devm_clk_get_enabled() to simplify

Make use of devm_clk_get_enabled() to replace some code that effectively
open codes this new function.

To retain ordering move the request to a place that is executed later.
This way the time of enable keeps the same.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230313185333.2776785-1-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent fb37fdd0
...@@ -490,11 +490,6 @@ static int admv1013_init(struct admv1013_state *st) ...@@ -490,11 +490,6 @@ static int admv1013_init(struct admv1013_state *st)
st->input_mode); st->input_mode);
} }
static void admv1013_clk_disable(void *data)
{
clk_disable_unprepare(data);
}
static void admv1013_reg_disable(void *data) static void admv1013_reg_disable(void *data)
{ {
regulator_disable(data); regulator_disable(data);
...@@ -559,11 +554,6 @@ static int admv1013_properties_parse(struct admv1013_state *st) ...@@ -559,11 +554,6 @@ static int admv1013_properties_parse(struct admv1013_state *st)
return dev_err_probe(&spi->dev, PTR_ERR(st->reg), return dev_err_probe(&spi->dev, PTR_ERR(st->reg),
"failed to get the common-mode voltage\n"); "failed to get the common-mode voltage\n");
st->clkin = devm_clk_get(&spi->dev, "lo_in");
if (IS_ERR(st->clkin))
return dev_err_probe(&spi->dev, PTR_ERR(st->clkin),
"failed to get the LO input clock\n");
return 0; return 0;
} }
...@@ -601,13 +591,10 @@ static int admv1013_probe(struct spi_device *spi) ...@@ -601,13 +591,10 @@ static int admv1013_probe(struct spi_device *spi)
if (ret) if (ret)
return ret; return ret;
ret = clk_prepare_enable(st->clkin); st->clkin = devm_clk_get_enabled(&spi->dev, "lo_in");
if (ret) if (IS_ERR(st->clkin))
return ret; return dev_err_probe(&spi->dev, PTR_ERR(st->clkin),
"failed to get the LO input clock\n");
ret = devm_add_action_or_reset(&spi->dev, admv1013_clk_disable, st->clkin);
if (ret)
return ret;
st->nb.notifier_call = admv1013_freq_change; st->nb.notifier_call = admv1013_freq_change;
ret = devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb); ret = devm_clk_notifier_register(&spi->dev, st->clkin, &st->nb);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment