Commit 772ae99c authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang

i2c: eg20t: pass on return value in i2c_xfer

smatch says:
drivers/i2c/busses/i2c-eg20t.c:702 pch_i2c_xfer() info: why not propagate 'ret' from mutex_lock_interruptible() instead of -512?

which is especially true since for -ENORESTARTSYS it is said in
linux/errno.h "signal_pending() MUST be set" which is not done here. So
just pass on the return value we got.
Signed-off-by: default avatarWolfram Sang <wolfram@the-dreams.de>
Cc: Tomoya MORINAGA <tomoya.rohm@gmail.com>
parent 75fb1f25
...@@ -699,7 +699,7 @@ static s32 pch_i2c_xfer(struct i2c_adapter *i2c_adap, ...@@ -699,7 +699,7 @@ static s32 pch_i2c_xfer(struct i2c_adapter *i2c_adap,
ret = mutex_lock_interruptible(&pch_mutex); ret = mutex_lock_interruptible(&pch_mutex);
if (ret) if (ret)
return -ERESTARTSYS; return ret;
if (adap->p_adapter_info->pch_i2c_suspended) { if (adap->p_adapter_info->pch_i2c_suspended) {
mutex_unlock(&pch_mutex); mutex_unlock(&pch_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment