Commit 77516d25 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe

rsxx: Return -EFAULT if copy_to_user() fails

The copy_to_user() function returns the number of bytes remaining but
we want to return -EFAULT to the user if it can't complete the copy.
The "st" variable only holds zero on success or negative error codes on
failure so the type should be int.

Fixes: 36f988e9 ("rsxx: Adding in debugfs entries.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4168a8d2
...@@ -165,15 +165,17 @@ static ssize_t rsxx_cram_read(struct file *fp, char __user *ubuf, ...@@ -165,15 +165,17 @@ static ssize_t rsxx_cram_read(struct file *fp, char __user *ubuf,
{ {
struct rsxx_cardinfo *card = file_inode(fp)->i_private; struct rsxx_cardinfo *card = file_inode(fp)->i_private;
char *buf; char *buf;
ssize_t st; int st;
buf = kzalloc(cnt, GFP_KERNEL); buf = kzalloc(cnt, GFP_KERNEL);
if (!buf) if (!buf)
return -ENOMEM; return -ENOMEM;
st = rsxx_creg_read(card, CREG_ADD_CRAM + (u32)*ppos, cnt, buf, 1); st = rsxx_creg_read(card, CREG_ADD_CRAM + (u32)*ppos, cnt, buf, 1);
if (!st) if (!st) {
st = copy_to_user(ubuf, buf, cnt); if (copy_to_user(ubuf, buf, cnt))
st = -EFAULT;
}
kfree(buf); kfree(buf);
if (st) if (st)
return st; return st;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment