Commit 78012e38 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Daniel Lezcano

clocksource/drivers/sh_mtu2: Mark driver as non-removable

The comment in the remove callback suggests that the driver is not
supposed to be unbound. However returning an error code in the remove
callback doesn't accomplish that. Instead set the suppress_bind_attrs
property (which makes it impossible to unbind the driver via sysfs).
The only remaining way to unbind a sh_tmu2 device would be module
unloading, but that doesn't apply here, as the driver cannot be built as
a module.

Also drop the useless remove callback.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230313075430.2730803-2-u.kleine-koenig@pengutronix.de
parent 0fabf9f3
...@@ -484,11 +484,6 @@ static int sh_mtu2_probe(struct platform_device *pdev) ...@@ -484,11 +484,6 @@ static int sh_mtu2_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int sh_mtu2_remove(struct platform_device *pdev)
{
return -EBUSY; /* cannot unregister clockevent */
}
static const struct platform_device_id sh_mtu2_id_table[] = { static const struct platform_device_id sh_mtu2_id_table[] = {
{ "sh-mtu2", 0 }, { "sh-mtu2", 0 },
{ }, { },
...@@ -503,10 +498,10 @@ MODULE_DEVICE_TABLE(of, sh_mtu2_of_table); ...@@ -503,10 +498,10 @@ MODULE_DEVICE_TABLE(of, sh_mtu2_of_table);
static struct platform_driver sh_mtu2_device_driver = { static struct platform_driver sh_mtu2_device_driver = {
.probe = sh_mtu2_probe, .probe = sh_mtu2_probe,
.remove = sh_mtu2_remove,
.driver = { .driver = {
.name = "sh_mtu2", .name = "sh_mtu2",
.of_match_table = of_match_ptr(sh_mtu2_of_table), .of_match_table = of_match_ptr(sh_mtu2_of_table),
.suppress_bind_attrs = true,
}, },
.id_table = sh_mtu2_id_table, .id_table = sh_mtu2_id_table,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment