Commit 78a2bb48 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Lee Jones

backlight: da9052_bl: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarAdam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230308073945.2336302-5-u.kleine-koenig@pengutronix.de
parent f6672d7f
...@@ -135,7 +135,7 @@ static int da9052_backlight_probe(struct platform_device *pdev) ...@@ -135,7 +135,7 @@ static int da9052_backlight_probe(struct platform_device *pdev)
return da9052_adjust_wled_brightness(wleds); return da9052_adjust_wled_brightness(wleds);
} }
static int da9052_backlight_remove(struct platform_device *pdev) static void da9052_backlight_remove(struct platform_device *pdev)
{ {
struct backlight_device *bl = platform_get_drvdata(pdev); struct backlight_device *bl = platform_get_drvdata(pdev);
struct da9052_bl *wleds = bl_get_data(bl); struct da9052_bl *wleds = bl_get_data(bl);
...@@ -143,8 +143,6 @@ static int da9052_backlight_remove(struct platform_device *pdev) ...@@ -143,8 +143,6 @@ static int da9052_backlight_remove(struct platform_device *pdev)
wleds->brightness = 0; wleds->brightness = 0;
wleds->state = DA9052_WLEDS_OFF; wleds->state = DA9052_WLEDS_OFF;
da9052_adjust_wled_brightness(wleds); da9052_adjust_wled_brightness(wleds);
return 0;
} }
static const struct platform_device_id da9052_wled_ids[] = { static const struct platform_device_id da9052_wled_ids[] = {
...@@ -166,7 +164,7 @@ MODULE_DEVICE_TABLE(platform, da9052_wled_ids); ...@@ -166,7 +164,7 @@ MODULE_DEVICE_TABLE(platform, da9052_wled_ids);
static struct platform_driver da9052_wled_driver = { static struct platform_driver da9052_wled_driver = {
.probe = da9052_backlight_probe, .probe = da9052_backlight_probe,
.remove = da9052_backlight_remove, .remove_new = da9052_backlight_remove,
.id_table = da9052_wled_ids, .id_table = da9052_wled_ids,
.driver = { .driver = {
.name = "da9052-wled", .name = "da9052-wled",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment