Commit 797b0159 authored by Lucas Stach's avatar Lucas Stach

drm/etnaviv: move exec_state to submit object

We'll need this in some places where only the submit is available. Also
this is a first step at slimming down the cmdbuf object.
Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
parent ef146c00
...@@ -297,14 +297,14 @@ void etnaviv_sync_point_queue(struct etnaviv_gpu *gpu, unsigned int event) ...@@ -297,14 +297,14 @@ void etnaviv_sync_point_queue(struct etnaviv_gpu *gpu, unsigned int event)
} }
/* Append a command buffer to the ring buffer. */ /* Append a command buffer to the ring buffer. */
void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, unsigned int event, void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,
struct etnaviv_cmdbuf *cmdbuf) unsigned int event, struct etnaviv_cmdbuf *cmdbuf)
{ {
struct etnaviv_cmdbuf *buffer = gpu->buffer; struct etnaviv_cmdbuf *buffer = gpu->buffer;
unsigned int waitlink_offset = buffer->user_size - 16; unsigned int waitlink_offset = buffer->user_size - 16;
u32 return_target, return_dwords; u32 return_target, return_dwords;
u32 link_target, link_dwords; u32 link_target, link_dwords;
bool switch_context = gpu->exec_state != cmdbuf->exec_state; bool switch_context = gpu->exec_state != exec_state;
lockdep_assert_held(&gpu->lock); lockdep_assert_held(&gpu->lock);
...@@ -363,8 +363,8 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, unsigned int event, ...@@ -363,8 +363,8 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, unsigned int event,
} }
if (switch_context) { if (switch_context) {
etnaviv_cmd_select_pipe(gpu, buffer, cmdbuf->exec_state); etnaviv_cmd_select_pipe(gpu, buffer, exec_state);
gpu->exec_state = cmdbuf->exec_state; gpu->exec_state = exec_state;
} }
/* And the link to the submitted buffer */ /* And the link to the submitted buffer */
......
...@@ -35,8 +35,6 @@ struct etnaviv_cmdbuf { ...@@ -35,8 +35,6 @@ struct etnaviv_cmdbuf {
u32 user_size; u32 user_size;
/* fence after which this buffer is to be disposed */ /* fence after which this buffer is to be disposed */
struct dma_fence *fence; struct dma_fence *fence;
/* target exec state */
u32 exec_state;
/* per GPU in-flight list */ /* per GPU in-flight list */
struct list_head node; struct list_head node;
/* BOs attached to this command buffer */ /* BOs attached to this command buffer */
......
...@@ -87,8 +87,8 @@ u16 etnaviv_buffer_init(struct etnaviv_gpu *gpu); ...@@ -87,8 +87,8 @@ u16 etnaviv_buffer_init(struct etnaviv_gpu *gpu);
u16 etnaviv_buffer_config_mmuv2(struct etnaviv_gpu *gpu, u32 mtlb_addr, u32 safe_addr); u16 etnaviv_buffer_config_mmuv2(struct etnaviv_gpu *gpu, u32 mtlb_addr, u32 safe_addr);
void etnaviv_buffer_end(struct etnaviv_gpu *gpu); void etnaviv_buffer_end(struct etnaviv_gpu *gpu);
void etnaviv_sync_point_queue(struct etnaviv_gpu *gpu, unsigned int event); void etnaviv_sync_point_queue(struct etnaviv_gpu *gpu, unsigned int event);
void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, unsigned int event, void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,
struct etnaviv_cmdbuf *cmdbuf); unsigned int event, struct etnaviv_cmdbuf *cmdbuf);
void etnaviv_validate_init(void); void etnaviv_validate_init(void);
bool etnaviv_cmd_validate_one(struct etnaviv_gpu *gpu, bool etnaviv_cmd_validate_one(struct etnaviv_gpu *gpu,
u32 *stream, unsigned int size, u32 *stream, unsigned int size,
......
...@@ -103,6 +103,7 @@ struct etnaviv_gem_submit { ...@@ -103,6 +103,7 @@ struct etnaviv_gem_submit {
struct kref refcount; struct kref refcount;
struct etnaviv_gpu *gpu; struct etnaviv_gpu *gpu;
struct dma_fence *out_fence, *in_fence; struct dma_fence *out_fence, *in_fence;
u32 exec_state;
u32 flags; u32 flags;
unsigned int nr_pmrs; unsigned int nr_pmrs;
struct etnaviv_perfmon_request *pmrs; struct etnaviv_perfmon_request *pmrs;
......
...@@ -440,7 +440,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, ...@@ -440,7 +440,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
goto err_submit_cmds; goto err_submit_cmds;
} }
cmdbuf->exec_state = args->exec_state;
cmdbuf->ctx = file->driver_priv; cmdbuf->ctx = file->driver_priv;
ret = copy_from_user(bos, u64_to_user_ptr(args->bos), ret = copy_from_user(bos, u64_to_user_ptr(args->bos),
...@@ -487,6 +486,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, ...@@ -487,6 +486,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
goto err_submit_ww_acquire; goto err_submit_ww_acquire;
} }
submit->exec_state = args->exec_state;
submit->flags = args->flags; submit->flags = args->flags;
ret = submit_lookup_objects(submit, file, bos, args->nr_bos); ret = submit_lookup_objects(submit, file, bos, args->nr_bos);
......
...@@ -1423,7 +1423,7 @@ int etnaviv_gpu_submit(struct etnaviv_gpu *gpu, ...@@ -1423,7 +1423,7 @@ int etnaviv_gpu_submit(struct etnaviv_gpu *gpu,
etnaviv_sync_point_queue(gpu, event[1]); etnaviv_sync_point_queue(gpu, event[1]);
} }
etnaviv_buffer_queue(gpu, event[0], cmdbuf); etnaviv_buffer_queue(gpu, submit->exec_state, event[0], cmdbuf);
if (submit->nr_pmrs) { if (submit->nr_pmrs) {
gpu->event[event[2]].sync_point = &sync_point_perfmon_sample_post; gpu->event[event[2]].sync_point = &sync_point_perfmon_sample_post;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment