Commit 7a3f0984 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

tty: rocket: fix invalid user-pointer checks

Drop invalid user-pointer checks from custom ioctl handlers.

A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6f8ada12
...@@ -1189,8 +1189,6 @@ static int get_config(struct r_port *info, struct rocket_config __user *retinfo) ...@@ -1189,8 +1189,6 @@ static int get_config(struct r_port *info, struct rocket_config __user *retinfo)
{ {
struct rocket_config tmp; struct rocket_config tmp;
if (!retinfo)
return -EFAULT;
memset(&tmp, 0, sizeof (tmp)); memset(&tmp, 0, sizeof (tmp));
mutex_lock(&info->port.mutex); mutex_lock(&info->port.mutex);
tmp.line = info->line; tmp.line = info->line;
...@@ -1255,8 +1253,6 @@ static int get_ports(struct r_port *info, struct rocket_ports __user *retports) ...@@ -1255,8 +1253,6 @@ static int get_ports(struct r_port *info, struct rocket_ports __user *retports)
struct rocket_ports tmp; struct rocket_ports tmp;
int board; int board;
if (!retports)
return -EFAULT;
memset(&tmp, 0, sizeof (tmp)); memset(&tmp, 0, sizeof (tmp));
tmp.tty_major = rocket_driver->major; tmp.tty_major = rocket_driver->major;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment