Commit 7b027c24 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Jakub Kicinski

net: b44: fix error return code in b44_init_one()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 39a6f4bc ("b44: replace the ssb_dma API with the generic DMA API")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/1605582131-36735-1-git-send-email-zhangchangzhong@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cb47d16e
...@@ -2383,7 +2383,8 @@ static int b44_init_one(struct ssb_device *sdev, ...@@ -2383,7 +2383,8 @@ static int b44_init_one(struct ssb_device *sdev,
goto err_out_free_dev; goto err_out_free_dev;
} }
if (dma_set_mask_and_coherent(sdev->dma_dev, DMA_BIT_MASK(30))) { err = dma_set_mask_and_coherent(sdev->dma_dev, DMA_BIT_MASK(30));
if (err) {
dev_err(sdev->dev, dev_err(sdev->dev,
"Required 30BIT DMA mask unsupported by the system\n"); "Required 30BIT DMA mask unsupported by the system\n");
goto err_out_powerdown; goto err_out_powerdown;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment