Commit 7b2fd270 authored by Amy Shih's avatar Amy Shih Committed by Guenter Roeck

hwmon: (nct7904) Fix incorrect range of temperature limit registers

The format of temperature limitation registers are 8-bit 2's complement
and the range is -128~127.
Converts the reading value to signed char to fix the incorrect range
of temperature limitation registers.
Signed-off-by: default avatarAmy Shih <amy.shih@advantech.com.tw>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 6d44e43f
...@@ -362,6 +362,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel, ...@@ -362,6 +362,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
struct nct7904_data *data = dev_get_drvdata(dev); struct nct7904_data *data = dev_get_drvdata(dev);
int ret, temp; int ret, temp;
unsigned int reg1, reg2, reg3; unsigned int reg1, reg2, reg3;
s8 temps;
switch (attr) { switch (attr) {
case hwmon_temp_input: case hwmon_temp_input:
...@@ -467,7 +468,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel, ...@@ -467,7 +468,8 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
if (ret < 0) if (ret < 0)
return ret; return ret;
*val = ret * 1000; temps = ret;
*val = temps * 1000;
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment