Commit 7bff0af5 authored by Shaohua Li's avatar Shaohua Li Committed by Thomas Gleixner

x86/intel_rdt: Propagate error in rdt_mount() properly

gcc complains:
"warning: ‘dentry’ may be used uninitialized in this function"

The error exit path in rdt_mount(), which deals with a failure in
rdtgroup_create_info_dir(), does not set the error code in dentry and
returns the uninitialized dentry value.

Add the missing error propagation.

[tglx: Massaged changelog ]
Fixes: 4e978d06 ("x86/intel_rdt: Add "info" files to resctrl file system")
Signed-off-by: default avatarShaohua Li <shli@fb.com>
Cc: fenghua.yu@intel.com
Cc: tony.luck@intel.com
Link: http://lkml.kernel.org/r/a56a556f6768dc12cadbf97f49e000189056f90e.1478207143.git.shli@fb.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 8ff42c02
...@@ -691,8 +691,10 @@ static struct dentry *rdt_mount(struct file_system_type *fs_type, ...@@ -691,8 +691,10 @@ static struct dentry *rdt_mount(struct file_system_type *fs_type,
closid_init(); closid_init();
ret = rdtgroup_create_info_dir(rdtgroup_default.kn); ret = rdtgroup_create_info_dir(rdtgroup_default.kn);
if (ret) if (ret) {
dentry = ERR_PTR(ret);
goto out_cdp; goto out_cdp;
}
dentry = kernfs_mount(fs_type, flags, rdt_root, dentry = kernfs_mount(fs_type, flags, rdt_root,
RDTGROUP_SUPER_MAGIC, NULL); RDTGROUP_SUPER_MAGIC, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment