Commit 7c6dd961 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar

x86/boot: Avoid using Intel mnemonics in AT&T syntax asm

With 'GNU assembler (GNU Binutils for Debian) 2.39.90.20221231' the
build now reports:

  arch/x86/realmode/rm/../../boot/bioscall.S: Assembler messages:
  arch/x86/realmode/rm/../../boot/bioscall.S:35: Warning: found `movsd'; assuming `movsl' was meant
  arch/x86/realmode/rm/../../boot/bioscall.S:70: Warning: found `movsd'; assuming `movsl' was meant

  arch/x86/boot/bioscall.S: Assembler messages:
  arch/x86/boot/bioscall.S:35: Warning: found `movsd'; assuming `movsl' was meant
  arch/x86/boot/bioscall.S:70: Warning: found `movsd'; assuming `movsl' was meant

Which is due to:

  PR gas/29525

  Note that with the dropped CMPSD and MOVSD Intel Syntax string insn
  templates taking operands, mixed IsString/non-IsString template groups
  (with memory operands) cannot occur anymore. With that
  maybe_adjust_templates() becomes unnecessary (and is hence being
  removed).

More details: https://sourceware.org/bugzilla/show_bug.cgi?id=29525

Borislav Petkov further explains:

  " the particular problem here is is that the 'd' suffix is
    "conflicting" in the sense that you can have SSE mnemonics like movsD %xmm...
    and the same thing also for string ops (which is the case here) so apparently
    the agreement in binutils land is to use the always accepted suffixes 'l' or 'q'
    and phase out 'd' slowly... "

Fixes: 7a734e7d ("x86, setup: "glove box" BIOS calls -- infrastructure")
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Acked-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/Y71I3Ex2pvIxMpsP@hirez.programming.kicks-ass.net
parent b7bfaa76
...@@ -32,7 +32,7 @@ intcall: ...@@ -32,7 +32,7 @@ intcall:
movw %dx, %si movw %dx, %si
movw %sp, %di movw %sp, %di
movw $11, %cx movw $11, %cx
rep; movsd rep; movsl
/* Pop full state from the stack */ /* Pop full state from the stack */
popal popal
...@@ -67,7 +67,7 @@ intcall: ...@@ -67,7 +67,7 @@ intcall:
jz 4f jz 4f
movw %sp, %si movw %sp, %si
movw $11, %cx movw $11, %cx
rep; movsd rep; movsl
4: addw $44, %sp 4: addw $44, %sp
/* Restore state and return */ /* Restore state and return */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment