Commit 7c91d020 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown

ASoC: qcom: sm8250: Fix array out of bounds access

Static analysis Coverity had detected a potential array out-of-bounds
write issue due to the fact that MAX AFE port Id was set to 16 instead
of using AFE_PORT_MAX macro.

Fix this by properly using AFE_PORT_MAX macro.

Fixes: aa2e2785 ("ASoC: qcom: sm8250: add sound card qrb5165-rb5 support")
Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20201028142001.22431-1-srinivas.kandagatla@linaro.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent e4c164d6
...@@ -13,12 +13,11 @@ ...@@ -13,12 +13,11 @@
#define DRIVER_NAME "sm8250" #define DRIVER_NAME "sm8250"
#define MI2S_BCLK_RATE 1536000 #define MI2S_BCLK_RATE 1536000
#define MAX_SDW_STREAMS 16
struct sm8250_snd_data { struct sm8250_snd_data {
bool stream_prepared[MAX_SDW_STREAMS]; bool stream_prepared[AFE_PORT_MAX];
struct snd_soc_card *card; struct snd_soc_card *card;
struct sdw_stream_runtime *sruntime[MAX_SDW_STREAMS]; struct sdw_stream_runtime *sruntime[AFE_PORT_MAX];
}; };
static int sm8250_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd, static int sm8250_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment