Commit 7ceeb6a4 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Pierre Ossman

mmc/omap: make mmci-omap using platform_driver_probe

A pointer to mmc_omap_probe which lives in .init.text is passed to the
core via platform_driver_register and so the kernel might oops if probe
is called after the init code is discarded.

As requested by David Brownell platform_driver_probe is used instead of
moving the probe function to .devinit.text.  This saves some memory, but
might have the downside that a device being registered after the call to
mmc_omap_init but before the init sections are discarded will not be
bound anymore to the driver.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarPierre Ossman <pierre@ossman.eu>
parent 5cf20aa5
...@@ -1593,7 +1593,6 @@ static int mmc_omap_resume(struct platform_device *pdev) ...@@ -1593,7 +1593,6 @@ static int mmc_omap_resume(struct platform_device *pdev)
#endif #endif
static struct platform_driver mmc_omap_driver = { static struct platform_driver mmc_omap_driver = {
.probe = mmc_omap_probe,
.remove = mmc_omap_remove, .remove = mmc_omap_remove,
.suspend = mmc_omap_suspend, .suspend = mmc_omap_suspend,
.resume = mmc_omap_resume, .resume = mmc_omap_resume,
...@@ -1605,7 +1604,7 @@ static struct platform_driver mmc_omap_driver = { ...@@ -1605,7 +1604,7 @@ static struct platform_driver mmc_omap_driver = {
static int __init mmc_omap_init(void) static int __init mmc_omap_init(void)
{ {
return platform_driver_register(&mmc_omap_driver); return platform_driver_probe(&mmc_omap_driver, mmc_omap_probe);
} }
static void __exit mmc_omap_exit(void) static void __exit mmc_omap_exit(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment