Commit 7d5bd969 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Greg Kroah-Hartman

net: tulip: Adjust indentation in {dmfe, uli526x}_init_module

commit fe06bf3d upstream.

Clang warns:

../drivers/net/ethernet/dec/tulip/uli526x.c:1812:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch (mode) {
        ^
../drivers/net/ethernet/dec/tulip/uli526x.c:1809:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

../drivers/net/ethernet/dec/tulip/dmfe.c:2217:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        switch(mode) {
        ^
../drivers/net/ethernet/dec/tulip/dmfe.c:2214:2: note: previous
statement is here
        if (cr6set)
        ^
1 warning generated.

This warning occurs because there is a space before the tab on these
lines. Remove them so that the indentation is consistent with the Linux
kernel coding style and clang no longer warns.

While we are here, adjust the default block in dmfe_init_module to have
a proper break between the label and assignment and add a space between
the switch and opening parentheses to avoid a checkpatch warning.

Fixes: e1c3e501 ("[PATCH] initialisation cleanup for ULI526x-net-driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/795Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fe96f9d0
...@@ -2222,15 +2222,16 @@ static int __init dmfe_init_module(void) ...@@ -2222,15 +2222,16 @@ static int __init dmfe_init_module(void)
if (cr6set) if (cr6set)
dmfe_cr6_user_set = cr6set; dmfe_cr6_user_set = cr6set;
switch(mode) { switch (mode) {
case DMFE_10MHF: case DMFE_10MHF:
case DMFE_100MHF: case DMFE_100MHF:
case DMFE_10MFD: case DMFE_10MFD:
case DMFE_100MFD: case DMFE_100MFD:
case DMFE_1M_HPNA: case DMFE_1M_HPNA:
dmfe_media_mode = mode; dmfe_media_mode = mode;
break; break;
default:dmfe_media_mode = DMFE_AUTO; default:
dmfe_media_mode = DMFE_AUTO;
break; break;
} }
......
...@@ -1817,8 +1817,8 @@ static int __init uli526x_init_module(void) ...@@ -1817,8 +1817,8 @@ static int __init uli526x_init_module(void)
if (cr6set) if (cr6set)
uli526x_cr6_user_set = cr6set; uli526x_cr6_user_set = cr6set;
switch (mode) { switch (mode) {
case ULI526X_10MHF: case ULI526X_10MHF:
case ULI526X_100MHF: case ULI526X_100MHF:
case ULI526X_10MFD: case ULI526X_10MFD:
case ULI526X_100MFD: case ULI526X_100MFD:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment