Commit 7d8d2019 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'timers-core-2023-04-28' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull more timer updates from Thomas Gleixner:
 "Timekeeping and clocksource/event driver updates the second batch:

   - A trivial documentation fix in the timekeeping core

   - A really boring set of small fixes, enhancements and cleanups in
     the drivers code. No new clocksource/clockevent drivers for a
     change"

* tag 'timers-core-2023-04-28' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  timekeeping: Fix references to nonexistent ktime_get_fast_ns()
  dt-bindings: timer: rockchip: Add rk3588 compatible
  dt-bindings: timer: rockchip: Drop superfluous rk3288 compatible
  clocksource/drivers/ti: Use of_property_read_bool() for boolean properties
  clocksource/drivers/timer-ti-dm: Fix finding alwon timer
  clocksource/drivers/davinci: Fix memory leak in davinci_timer_register when init fails
  clocksource/drivers/stm32-lp: Drop of_match_ptr for ID table
  clocksource/drivers/timer-ti-dm: Convert to platform remove callback returning void
  clocksource/drivers/timer-tegra186: Convert to platform remove callback returning void
  clocksource/drivers/timer-ti-dm: Improve error message in .remove
  clocksource/drivers/timer-stm32-lp: Mark driver as non-removable
  clocksource/drivers/sh_mtu2: Mark driver as non-removable
  clocksource/drivers/timer-ti-dm: Use of_address_to_resource()
  clocksource/drivers/timer-imx-gpt: Remove non-DT function
  clocksource/drivers/timer-mediatek: Split out CPUXGPT timers
  clocksource/drivers/exynos_mct: Explicitly return 0 for shared timer
parents 8c1318e4 158009f1
...@@ -23,8 +23,8 @@ properties: ...@@ -23,8 +23,8 @@ properties:
- rockchip,rk3188-timer - rockchip,rk3188-timer
- rockchip,rk3228-timer - rockchip,rk3228-timer
- rockchip,rk3229-timer - rockchip,rk3229-timer
- rockchip,rk3288-timer
- rockchip,rk3368-timer - rockchip,rk3368-timer
- rockchip,rk3588-timer
- rockchip,px30-timer - rockchip,px30-timer
- const: rockchip,rk3288-timer - const: rockchip,rk3288-timer
reg: reg:
......
...@@ -479,6 +479,15 @@ config MTK_TIMER ...@@ -479,6 +479,15 @@ config MTK_TIMER
help help
Support for Mediatek timer driver. Support for Mediatek timer driver.
config MTK_CPUX_TIMER
bool "MediaTek CPUX timer driver" if COMPILE_TEST
depends on HAS_IOMEM
default ARCH_MEDIATEK
select TIMER_OF
select CLKSRC_MMIO
help
Support for MediaTek CPUXGPT timer driver.
config SPRD_TIMER config SPRD_TIMER
bool "Spreadtrum timer driver" if EXPERT bool "Spreadtrum timer driver" if EXPERT
depends on HAS_IOMEM depends on HAS_IOMEM
......
...@@ -51,6 +51,7 @@ obj-$(CONFIG_FSL_FTM_TIMER) += timer-fsl-ftm.o ...@@ -51,6 +51,7 @@ obj-$(CONFIG_FSL_FTM_TIMER) += timer-fsl-ftm.o
obj-$(CONFIG_VF_PIT_TIMER) += timer-vf-pit.o obj-$(CONFIG_VF_PIT_TIMER) += timer-vf-pit.o
obj-$(CONFIG_CLKSRC_QCOM) += timer-qcom.o obj-$(CONFIG_CLKSRC_QCOM) += timer-qcom.o
obj-$(CONFIG_MTK_TIMER) += timer-mediatek.o obj-$(CONFIG_MTK_TIMER) += timer-mediatek.o
obj-$(CONFIG_MTK_CPUX_TIMER) += timer-mediatek-cpux.o
obj-$(CONFIG_CLKSRC_PISTACHIO) += timer-pistachio.o obj-$(CONFIG_CLKSRC_PISTACHIO) += timer-pistachio.o
obj-$(CONFIG_CLKSRC_TI_32K) += timer-ti-32k.o obj-$(CONFIG_CLKSRC_TI_32K) += timer-ti-32k.o
obj-$(CONFIG_OXNAS_RPS_TIMER) += timer-oxnas-rps.o obj-$(CONFIG_OXNAS_RPS_TIMER) += timer-oxnas-rps.o
......
...@@ -682,7 +682,7 @@ static int __init mct_init_dt(struct device_node *np, unsigned int int_type) ...@@ -682,7 +682,7 @@ static int __init mct_init_dt(struct device_node *np, unsigned int int_type)
* processor cannot use the global comparator. * processor cannot use the global comparator.
*/ */
if (frc_shared) if (frc_shared)
return ret; return 0;
return exynos4_clockevent_init(); return exynos4_clockevent_init();
} }
......
...@@ -484,11 +484,6 @@ static int sh_mtu2_probe(struct platform_device *pdev) ...@@ -484,11 +484,6 @@ static int sh_mtu2_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int sh_mtu2_remove(struct platform_device *pdev)
{
return -EBUSY; /* cannot unregister clockevent */
}
static const struct platform_device_id sh_mtu2_id_table[] = { static const struct platform_device_id sh_mtu2_id_table[] = {
{ "sh-mtu2", 0 }, { "sh-mtu2", 0 },
{ }, { },
...@@ -503,10 +498,10 @@ MODULE_DEVICE_TABLE(of, sh_mtu2_of_table); ...@@ -503,10 +498,10 @@ MODULE_DEVICE_TABLE(of, sh_mtu2_of_table);
static struct platform_driver sh_mtu2_device_driver = { static struct platform_driver sh_mtu2_device_driver = {
.probe = sh_mtu2_probe, .probe = sh_mtu2_probe,
.remove = sh_mtu2_remove,
.driver = { .driver = {
.name = "sh_mtu2", .name = "sh_mtu2",
.of_match_table = of_match_ptr(sh_mtu2_of_table), .of_match_table = of_match_ptr(sh_mtu2_of_table),
.suppress_bind_attrs = true,
}, },
.id_table = sh_mtu2_id_table, .id_table = sh_mtu2_id_table,
}; };
......
...@@ -257,21 +257,25 @@ int __init davinci_timer_register(struct clk *clk, ...@@ -257,21 +257,25 @@ int __init davinci_timer_register(struct clk *clk,
resource_size(&timer_cfg->reg), resource_size(&timer_cfg->reg),
"davinci-timer")) { "davinci-timer")) {
pr_err("Unable to request memory region\n"); pr_err("Unable to request memory region\n");
return -EBUSY; rv = -EBUSY;
goto exit_clk_disable;
} }
base = ioremap(timer_cfg->reg.start, resource_size(&timer_cfg->reg)); base = ioremap(timer_cfg->reg.start, resource_size(&timer_cfg->reg));
if (!base) { if (!base) {
pr_err("Unable to map the register range\n"); pr_err("Unable to map the register range\n");
return -ENOMEM; rv = -ENOMEM;
goto exit_mem_region;
} }
davinci_timer_init(base); davinci_timer_init(base);
tick_rate = clk_get_rate(clk); tick_rate = clk_get_rate(clk);
clockevent = kzalloc(sizeof(*clockevent), GFP_KERNEL); clockevent = kzalloc(sizeof(*clockevent), GFP_KERNEL);
if (!clockevent) if (!clockevent) {
return -ENOMEM; rv = -ENOMEM;
goto exit_iounmap_base;
}
clockevent->dev.name = "tim12"; clockevent->dev.name = "tim12";
clockevent->dev.features = CLOCK_EVT_FEAT_ONESHOT; clockevent->dev.features = CLOCK_EVT_FEAT_ONESHOT;
...@@ -296,7 +300,7 @@ int __init davinci_timer_register(struct clk *clk, ...@@ -296,7 +300,7 @@ int __init davinci_timer_register(struct clk *clk,
"clockevent/tim12", clockevent); "clockevent/tim12", clockevent);
if (rv) { if (rv) {
pr_err("Unable to request the clockevent interrupt\n"); pr_err("Unable to request the clockevent interrupt\n");
return rv; goto exit_free_clockevent;
} }
davinci_clocksource.dev.rating = 300; davinci_clocksource.dev.rating = 300;
...@@ -323,13 +327,27 @@ int __init davinci_timer_register(struct clk *clk, ...@@ -323,13 +327,27 @@ int __init davinci_timer_register(struct clk *clk,
rv = clocksource_register_hz(&davinci_clocksource.dev, tick_rate); rv = clocksource_register_hz(&davinci_clocksource.dev, tick_rate);
if (rv) { if (rv) {
pr_err("Unable to register clocksource\n"); pr_err("Unable to register clocksource\n");
return rv; goto exit_free_irq;
} }
sched_clock_register(davinci_timer_read_sched_clock, sched_clock_register(davinci_timer_read_sched_clock,
DAVINCI_TIMER_CLKSRC_BITS, tick_rate); DAVINCI_TIMER_CLKSRC_BITS, tick_rate);
return 0; return 0;
exit_free_irq:
free_irq(timer_cfg->irq[DAVINCI_TIMER_CLOCKEVENT_IRQ].start,
clockevent);
exit_free_clockevent:
kfree(clockevent);
exit_iounmap_base:
iounmap(base);
exit_mem_region:
release_mem_region(timer_cfg->reg.start,
resource_size(&timer_cfg->reg));
exit_clk_disable:
clk_disable_unprepare(clk);
return rv;
} }
static int __init of_davinci_timer_register(struct device_node *np) static int __init of_davinci_timer_register(struct device_node *np)
......
...@@ -420,25 +420,6 @@ static int __init _mxc_timer_init(struct imx_timer *imxtm) ...@@ -420,25 +420,6 @@ static int __init _mxc_timer_init(struct imx_timer *imxtm)
return mxc_clockevent_init(imxtm); return mxc_clockevent_init(imxtm);
} }
void __init mxc_timer_init(unsigned long pbase, int irq, enum imx_gpt_type type)
{
struct imx_timer *imxtm;
imxtm = kzalloc(sizeof(*imxtm), GFP_KERNEL);
BUG_ON(!imxtm);
imxtm->clk_per = clk_get_sys("imx-gpt.0", "per");
imxtm->clk_ipg = clk_get_sys("imx-gpt.0", "ipg");
imxtm->base = ioremap(pbase, SZ_4K);
BUG_ON(!imxtm->base);
imxtm->type = type;
imxtm->irq = irq;
_mxc_timer_init(imxtm);
}
static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type type) static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type type)
{ {
struct imx_timer *imxtm; struct imx_timer *imxtm;
......
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* MediaTek SoCs CPUX General Purpose Timer handling
*
* Based on timer-mediatek.c:
* Copyright (C) 2014 Matthias Brugger <matthias.bgg@gmail.com>
*
* Copyright (C) 2022 Collabora Ltd.
* AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
*/
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/clockchips.h>
#include <linux/clocksource.h>
#include <linux/interrupt.h>
#include <linux/irqreturn.h>
#include <linux/sched_clock.h>
#include <linux/slab.h>
#include "timer-of.h"
#define TIMER_SYNC_TICKS 3
/* cpux mcusys wrapper */
#define CPUX_CON_REG 0x0
#define CPUX_IDX_REG 0x4
/* cpux */
#define CPUX_IDX_GLOBAL_CTRL 0x0
#define CPUX_ENABLE BIT(0)
#define CPUX_CLK_DIV_MASK GENMASK(10, 8)
#define CPUX_CLK_DIV1 BIT(8)
#define CPUX_CLK_DIV2 BIT(9)
#define CPUX_CLK_DIV4 BIT(10)
#define CPUX_IDX_GLOBAL_IRQ 0x30
static u32 mtk_cpux_readl(u32 reg_idx, struct timer_of *to)
{
writel(reg_idx, timer_of_base(to) + CPUX_IDX_REG);
return readl(timer_of_base(to) + CPUX_CON_REG);
}
static void mtk_cpux_writel(u32 val, u32 reg_idx, struct timer_of *to)
{
writel(reg_idx, timer_of_base(to) + CPUX_IDX_REG);
writel(val, timer_of_base(to) + CPUX_CON_REG);
}
static void mtk_cpux_set_irq(struct timer_of *to, bool enable)
{
const unsigned long *irq_mask = cpumask_bits(cpu_possible_mask);
u32 val;
val = mtk_cpux_readl(CPUX_IDX_GLOBAL_IRQ, to);
if (enable)
val |= *irq_mask;
else
val &= ~(*irq_mask);
mtk_cpux_writel(val, CPUX_IDX_GLOBAL_IRQ, to);
}
static int mtk_cpux_clkevt_shutdown(struct clock_event_device *clkevt)
{
/* Clear any irq */
mtk_cpux_set_irq(to_timer_of(clkevt), false);
/*
* Disabling CPUXGPT timer will crash the platform, especially
* if Trusted Firmware is using it (usually, for sleep states),
* so we only mask the IRQ and call it a day.
*/
return 0;
}
static int mtk_cpux_clkevt_resume(struct clock_event_device *clkevt)
{
mtk_cpux_set_irq(to_timer_of(clkevt), true);
return 0;
}
static struct timer_of to = {
/*
* There are per-cpu interrupts for the CPUX General Purpose Timer
* but since this timer feeds the AArch64 System Timer we can rely
* on the CPU timer PPIs as well, so we don't declare TIMER_OF_IRQ.
*/
.flags = TIMER_OF_BASE | TIMER_OF_CLOCK,
.clkevt = {
.name = "mtk-cpuxgpt",
.cpumask = cpu_possible_mask,
.rating = 10,
.set_state_shutdown = mtk_cpux_clkevt_shutdown,
.tick_resume = mtk_cpux_clkevt_resume,
},
};
static int __init mtk_cpux_init(struct device_node *node)
{
u32 freq, val;
int ret;
/* If this fails, bad things are about to happen... */
ret = timer_of_init(node, &to);
if (ret) {
WARN(1, "Cannot start CPUX timers.\n");
return ret;
}
/*
* Check if we're given a clock with the right frequency for this
* timer, otherwise warn but keep going with the setup anyway, as
* that makes it possible to still boot the kernel, even though
* it may not work correctly (random lockups, etc).
* The reason behind this is that having an early UART may not be
* possible for everyone and this gives a chance to retrieve kmsg
* for eventual debugging even on consumer devices.
*/
freq = timer_of_rate(&to);
if (freq > 13000000)
WARN(1, "Requested unsupported timer frequency %u\n", freq);
/* Clock input is 26MHz, set DIV2 to achieve 13MHz clock */
val = mtk_cpux_readl(CPUX_IDX_GLOBAL_CTRL, &to);
val &= ~CPUX_CLK_DIV_MASK;
val |= CPUX_CLK_DIV2;
mtk_cpux_writel(val, CPUX_IDX_GLOBAL_CTRL, &to);
/* Enable all CPUXGPT timers */
val = mtk_cpux_readl(CPUX_IDX_GLOBAL_CTRL, &to);
mtk_cpux_writel(val | CPUX_ENABLE, CPUX_IDX_GLOBAL_CTRL, &to);
clockevents_config_and_register(&to.clkevt, timer_of_rate(&to),
TIMER_SYNC_TICKS, 0xffffffff);
return 0;
}
TIMER_OF_DECLARE(mtk_mt6795, "mediatek,mt6795-systimer", mtk_cpux_init);
...@@ -22,19 +22,6 @@ ...@@ -22,19 +22,6 @@
#define TIMER_SYNC_TICKS (3) #define TIMER_SYNC_TICKS (3)
/* cpux mcusys wrapper */
#define CPUX_CON_REG 0x0
#define CPUX_IDX_REG 0x4
/* cpux */
#define CPUX_IDX_GLOBAL_CTRL 0x0
#define CPUX_ENABLE BIT(0)
#define CPUX_CLK_DIV_MASK GENMASK(10, 8)
#define CPUX_CLK_DIV1 BIT(8)
#define CPUX_CLK_DIV2 BIT(9)
#define CPUX_CLK_DIV4 BIT(10)
#define CPUX_IDX_GLOBAL_IRQ 0x30
/* gpt */ /* gpt */
#define GPT_IRQ_EN_REG 0x00 #define GPT_IRQ_EN_REG 0x00
#define GPT_IRQ_ENABLE(val) BIT((val) - 1) #define GPT_IRQ_ENABLE(val) BIT((val) - 1)
...@@ -85,52 +72,6 @@ ...@@ -85,52 +72,6 @@
static void __iomem *gpt_sched_reg __read_mostly; static void __iomem *gpt_sched_reg __read_mostly;
static u32 mtk_cpux_readl(u32 reg_idx, struct timer_of *to)
{
writel(reg_idx, timer_of_base(to) + CPUX_IDX_REG);
return readl(timer_of_base(to) + CPUX_CON_REG);
}
static void mtk_cpux_writel(u32 val, u32 reg_idx, struct timer_of *to)
{
writel(reg_idx, timer_of_base(to) + CPUX_IDX_REG);
writel(val, timer_of_base(to) + CPUX_CON_REG);
}
static void mtk_cpux_set_irq(struct timer_of *to, bool enable)
{
const unsigned long *irq_mask = cpumask_bits(cpu_possible_mask);
u32 val;
val = mtk_cpux_readl(CPUX_IDX_GLOBAL_IRQ, to);
if (enable)
val |= *irq_mask;
else
val &= ~(*irq_mask);
mtk_cpux_writel(val, CPUX_IDX_GLOBAL_IRQ, to);
}
static int mtk_cpux_clkevt_shutdown(struct clock_event_device *clkevt)
{
/* Clear any irq */
mtk_cpux_set_irq(to_timer_of(clkevt), false);
/*
* Disabling CPUXGPT timer will crash the platform, especially
* if Trusted Firmware is using it (usually, for sleep states),
* so we only mask the IRQ and call it a day.
*/
return 0;
}
static int mtk_cpux_clkevt_resume(struct clock_event_device *clkevt)
{
mtk_cpux_set_irq(to_timer_of(clkevt), true);
return 0;
}
static void mtk_syst_ack_irq(struct timer_of *to) static void mtk_syst_ack_irq(struct timer_of *to)
{ {
/* Clear and disable interrupt */ /* Clear and disable interrupt */
...@@ -340,60 +281,6 @@ static struct timer_of to = { ...@@ -340,60 +281,6 @@ static struct timer_of to = {
}, },
}; };
static int __init mtk_cpux_init(struct device_node *node)
{
static struct timer_of to_cpux;
u32 freq, val;
int ret;
/*
* There are per-cpu interrupts for the CPUX General Purpose Timer
* but since this timer feeds the AArch64 System Timer we can rely
* on the CPU timer PPIs as well, so we don't declare TIMER_OF_IRQ.
*/
to_cpux.flags = TIMER_OF_BASE | TIMER_OF_CLOCK;
to_cpux.clkevt.name = "mtk-cpuxgpt";
to_cpux.clkevt.rating = 10;
to_cpux.clkevt.cpumask = cpu_possible_mask;
to_cpux.clkevt.set_state_shutdown = mtk_cpux_clkevt_shutdown;
to_cpux.clkevt.tick_resume = mtk_cpux_clkevt_resume;
/* If this fails, bad things are about to happen... */
ret = timer_of_init(node, &to_cpux);
if (ret) {
WARN(1, "Cannot start CPUX timers.\n");
return ret;
}
/*
* Check if we're given a clock with the right frequency for this
* timer, otherwise warn but keep going with the setup anyway, as
* that makes it possible to still boot the kernel, even though
* it may not work correctly (random lockups, etc).
* The reason behind this is that having an early UART may not be
* possible for everyone and this gives a chance to retrieve kmsg
* for eventual debugging even on consumer devices.
*/
freq = timer_of_rate(&to_cpux);
if (freq > 13000000)
WARN(1, "Requested unsupported timer frequency %u\n", freq);
/* Clock input is 26MHz, set DIV2 to achieve 13MHz clock */
val = mtk_cpux_readl(CPUX_IDX_GLOBAL_CTRL, &to_cpux);
val &= ~CPUX_CLK_DIV_MASK;
val |= CPUX_CLK_DIV2;
mtk_cpux_writel(val, CPUX_IDX_GLOBAL_CTRL, &to_cpux);
/* Enable all CPUXGPT timers */
val = mtk_cpux_readl(CPUX_IDX_GLOBAL_CTRL, &to_cpux);
mtk_cpux_writel(val | CPUX_ENABLE, CPUX_IDX_GLOBAL_CTRL, &to_cpux);
clockevents_config_and_register(&to_cpux.clkevt, timer_of_rate(&to_cpux),
TIMER_SYNC_TICKS, 0xffffffff);
return 0;
}
static int __init mtk_syst_init(struct device_node *node) static int __init mtk_syst_init(struct device_node *node)
{ {
int ret; int ret;
...@@ -452,4 +339,3 @@ static int __init mtk_gpt_init(struct device_node *node) ...@@ -452,4 +339,3 @@ static int __init mtk_gpt_init(struct device_node *node)
} }
TIMER_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_gpt_init); TIMER_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_gpt_init);
TIMER_OF_DECLARE(mtk_mt6765, "mediatek,mt6765-timer", mtk_syst_init); TIMER_OF_DECLARE(mtk_mt6765, "mediatek,mt6765-timer", mtk_syst_init);
TIMER_OF_DECLARE(mtk_mt6795, "mediatek,mt6795-systimer", mtk_cpux_init);
...@@ -195,11 +195,6 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev) ...@@ -195,11 +195,6 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int stm32_clkevent_lp_remove(struct platform_device *pdev)
{
return -EBUSY; /* cannot unregister clockevent */
}
static const struct of_device_id stm32_clkevent_lp_of_match[] = { static const struct of_device_id stm32_clkevent_lp_of_match[] = {
{ .compatible = "st,stm32-lptimer-timer", }, { .compatible = "st,stm32-lptimer-timer", },
{}, {},
...@@ -207,11 +202,11 @@ static const struct of_device_id stm32_clkevent_lp_of_match[] = { ...@@ -207,11 +202,11 @@ static const struct of_device_id stm32_clkevent_lp_of_match[] = {
MODULE_DEVICE_TABLE(of, stm32_clkevent_lp_of_match); MODULE_DEVICE_TABLE(of, stm32_clkevent_lp_of_match);
static struct platform_driver stm32_clkevent_lp_driver = { static struct platform_driver stm32_clkevent_lp_driver = {
.probe = stm32_clkevent_lp_probe, .probe = stm32_clkevent_lp_probe,
.remove = stm32_clkevent_lp_remove,
.driver = { .driver = {
.name = "stm32-lptimer-timer", .name = "stm32-lptimer-timer",
.of_match_table = of_match_ptr(stm32_clkevent_lp_of_match), .of_match_table = stm32_clkevent_lp_of_match,
.suppress_bind_attrs = true,
}, },
}; };
module_platform_driver(stm32_clkevent_lp_driver); module_platform_driver(stm32_clkevent_lp_driver);
......
...@@ -447,15 +447,13 @@ static int tegra186_timer_probe(struct platform_device *pdev) ...@@ -447,15 +447,13 @@ static int tegra186_timer_probe(struct platform_device *pdev)
return err; return err;
} }
static int tegra186_timer_remove(struct platform_device *pdev) static void tegra186_timer_remove(struct platform_device *pdev)
{ {
struct tegra186_timer *tegra = platform_get_drvdata(pdev); struct tegra186_timer *tegra = platform_get_drvdata(pdev);
clocksource_unregister(&tegra->usec); clocksource_unregister(&tegra->usec);
clocksource_unregister(&tegra->osc); clocksource_unregister(&tegra->osc);
clocksource_unregister(&tegra->tsc); clocksource_unregister(&tegra->tsc);
return 0;
} }
static int __maybe_unused tegra186_timer_suspend(struct device *dev) static int __maybe_unused tegra186_timer_suspend(struct device *dev)
...@@ -505,7 +503,7 @@ static struct platform_driver tegra186_wdt_driver = { ...@@ -505,7 +503,7 @@ static struct platform_driver tegra186_wdt_driver = {
.of_match_table = tegra186_timer_of_match, .of_match_table = tegra186_timer_of_match,
}, },
.probe = tegra186_timer_probe, .probe = tegra186_timer_probe,
.remove = tegra186_timer_remove, .remove_new = tegra186_timer_remove,
}; };
module_platform_driver(tegra186_wdt_driver); module_platform_driver(tegra186_wdt_driver);
......
...@@ -251,24 +251,24 @@ static void __init dmtimer_systimer_assign_alwon(void) ...@@ -251,24 +251,24 @@ static void __init dmtimer_systimer_assign_alwon(void)
counter_32k = -ENODEV; counter_32k = -ENODEV;
for_each_matching_node(np, dmtimer_match_table) { for_each_matching_node(np, dmtimer_match_table) {
struct resource res;
if (!dmtimer_is_preferred(np)) if (!dmtimer_is_preferred(np))
continue; continue;
if (of_property_read_bool(np, "ti,timer-alwon")) { if (!of_property_read_bool(np, "ti,timer-alwon"))
const __be32 *addr; continue;
addr = of_get_address(np, 0, NULL, NULL); if (of_address_to_resource(np, 0, &res))
pa = of_translate_address(np, addr); continue;
if (pa) {
/* Quirky omap3 boards must use dmtimer12 */ pa = res.start;
if (quirk_unreliable_oscillator &&
pa == 0x48318000) /* Quirky omap3 boards must use dmtimer12 */
continue; if (quirk_unreliable_oscillator && pa == 0x48318000)
continue;
of_node_put(np);
break; of_node_put(np);
} break;
}
} }
/* Usually no need for dmtimer clocksource if we have counter32 */ /* Usually no need for dmtimer clocksource if we have counter32 */
...@@ -285,24 +285,22 @@ static void __init dmtimer_systimer_assign_alwon(void) ...@@ -285,24 +285,22 @@ static void __init dmtimer_systimer_assign_alwon(void)
static u32 __init dmtimer_systimer_find_first_available(void) static u32 __init dmtimer_systimer_find_first_available(void)
{ {
struct device_node *np; struct device_node *np;
const __be32 *addr;
u32 pa = 0; u32 pa = 0;
for_each_matching_node(np, dmtimer_match_table) { for_each_matching_node(np, dmtimer_match_table) {
struct resource res;
if (!dmtimer_is_preferred(np)) if (!dmtimer_is_preferred(np))
continue; continue;
addr = of_get_address(np, 0, NULL, NULL); if (of_address_to_resource(np, 0, &res))
pa = of_translate_address(np, addr); continue;
if (pa) {
if (pa == clocksource || pa == clockevent) { if (res.start == clocksource || res.start == clockevent)
pa = 0; continue;
continue;
} pa = res.start;
of_node_put(np);
of_node_put(np); break;
break;
}
} }
return pa; return pa;
...@@ -586,7 +584,7 @@ static int __init dmtimer_clkevt_init_common(struct dmtimer_clockevent *clkevt, ...@@ -586,7 +584,7 @@ static int __init dmtimer_clkevt_init_common(struct dmtimer_clockevent *clkevt,
writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup); writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup);
pr_info("TI gptimer %s: %s%lu Hz at %pOF\n", pr_info("TI gptimer %s: %s%lu Hz at %pOF\n",
name, of_find_property(np, "ti,timer-alwon", NULL) ? name, of_property_read_bool(np, "ti,timer-alwon") ?
"always-on " : "", t->rate, np->parent); "always-on " : "", t->rate, np->parent);
return 0; return 0;
...@@ -787,7 +785,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np) ...@@ -787,7 +785,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
t->base + t->ctrl); t->base + t->ctrl);
pr_info("TI gptimer clocksource: %s%pOF\n", pr_info("TI gptimer clocksource: %s%pOF\n",
of_find_property(np, "ti,timer-alwon", NULL) ? of_property_read_bool(np, "ti,timer-alwon") ?
"always-on " : "", np->parent); "always-on " : "", np->parent);
if (!dmtimer_sched_clock_counter) { if (!dmtimer_sched_clock_counter) {
...@@ -812,7 +810,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np) ...@@ -812,7 +810,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
*/ */
static int __init dmtimer_systimer_init(struct device_node *np) static int __init dmtimer_systimer_init(struct device_node *np)
{ {
const __be32 *addr; struct resource res;
u32 pa; u32 pa;
/* One time init for the preferred timer configuration */ /* One time init for the preferred timer configuration */
...@@ -826,8 +824,9 @@ static int __init dmtimer_systimer_init(struct device_node *np) ...@@ -826,8 +824,9 @@ static int __init dmtimer_systimer_init(struct device_node *np)
return -EINVAL; return -EINVAL;
} }
addr = of_get_address(np, 0, NULL, NULL);
pa = of_translate_address(np, addr); of_address_to_resource(np, 0, &res);
pa = (u32)res.start;
if (!pa) if (!pa)
return -EINVAL; return -EINVAL;
......
...@@ -1104,13 +1104,13 @@ static int omap_dm_timer_probe(struct platform_device *pdev) ...@@ -1104,13 +1104,13 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, timer); platform_set_drvdata(pdev, timer);
if (dev->of_node) { if (dev->of_node) {
if (of_find_property(dev->of_node, "ti,timer-alwon", NULL)) if (of_property_read_bool(dev->of_node, "ti,timer-alwon"))
timer->capability |= OMAP_TIMER_ALWON; timer->capability |= OMAP_TIMER_ALWON;
if (of_find_property(dev->of_node, "ti,timer-dsp", NULL)) if (of_property_read_bool(dev->of_node, "ti,timer-dsp"))
timer->capability |= OMAP_TIMER_HAS_DSP_IRQ; timer->capability |= OMAP_TIMER_HAS_DSP_IRQ;
if (of_find_property(dev->of_node, "ti,timer-pwm", NULL)) if (of_property_read_bool(dev->of_node, "ti,timer-pwm"))
timer->capability |= OMAP_TIMER_HAS_PWM; timer->capability |= OMAP_TIMER_HAS_PWM;
if (of_find_property(dev->of_node, "ti,timer-secure", NULL)) if (of_property_read_bool(dev->of_node, "ti,timer-secure"))
timer->capability |= OMAP_TIMER_SECURE; timer->capability |= OMAP_TIMER_SECURE;
} else { } else {
timer->id = pdev->id; timer->id = pdev->id;
...@@ -1177,7 +1177,7 @@ static int omap_dm_timer_probe(struct platform_device *pdev) ...@@ -1177,7 +1177,7 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
* In addition to freeing platform resources it also deletes the timer * In addition to freeing platform resources it also deletes the timer
* entry from the local list. * entry from the local list.
*/ */
static int omap_dm_timer_remove(struct platform_device *pdev) static void omap_dm_timer_remove(struct platform_device *pdev)
{ {
struct dmtimer *timer; struct dmtimer *timer;
unsigned long flags; unsigned long flags;
...@@ -1197,7 +1197,8 @@ static int omap_dm_timer_remove(struct platform_device *pdev) ...@@ -1197,7 +1197,8 @@ static int omap_dm_timer_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return ret; if (ret)
dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n");
} }
static const struct omap_dm_timer_ops dmtimer_ops = { static const struct omap_dm_timer_ops dmtimer_ops = {
...@@ -1272,7 +1273,7 @@ MODULE_DEVICE_TABLE(of, omap_timer_match); ...@@ -1272,7 +1273,7 @@ MODULE_DEVICE_TABLE(of, omap_timer_match);
static struct platform_driver omap_dm_timer_driver = { static struct platform_driver omap_dm_timer_driver = {
.probe = omap_dm_timer_probe, .probe = omap_dm_timer_probe,
.remove = omap_dm_timer_remove, .remove_new = omap_dm_timer_remove,
.driver = { .driver = {
.name = "omap_timer", .name = "omap_timer",
.of_match_table = omap_timer_match, .of_match_table = omap_timer_match,
......
...@@ -13,11 +13,4 @@ enum imx_gpt_type { ...@@ -13,11 +13,4 @@ enum imx_gpt_type {
GPT_TYPE_IMX6DL, /* i.MX6DL/SX/SL */ GPT_TYPE_IMX6DL, /* i.MX6DL/SX/SL */
}; };
/*
* This is a stop-gap solution for clock drivers like imx1/imx21 which call
* mxc_timer_init() to initialize timer for non-DT boot. It can be removed
* when these legacy non-DT support is converted or dropped.
*/
void mxc_timer_init(unsigned long pbase, int irq, enum imx_gpt_type type);
#endif /* __SOC_IMX_TIMER_H__ */ #endif /* __SOC_IMX_TIMER_H__ */
...@@ -526,7 +526,7 @@ EXPORT_SYMBOL_GPL(ktime_get_raw_fast_ns); ...@@ -526,7 +526,7 @@ EXPORT_SYMBOL_GPL(ktime_get_raw_fast_ns);
* partially updated. Since the tk->offs_boot update is a rare event, this * partially updated. Since the tk->offs_boot update is a rare event, this
* should be a rare occurrence which postprocessing should be able to handle. * should be a rare occurrence which postprocessing should be able to handle.
* *
* The caveats vs. timestamp ordering as documented for ktime_get_fast_ns() * The caveats vs. timestamp ordering as documented for ktime_get_mono_fast_ns()
* apply as well. * apply as well.
*/ */
u64 notrace ktime_get_boot_fast_ns(void) u64 notrace ktime_get_boot_fast_ns(void)
...@@ -576,7 +576,7 @@ static __always_inline u64 __ktime_get_real_fast(struct tk_fast *tkf, u64 *mono) ...@@ -576,7 +576,7 @@ static __always_inline u64 __ktime_get_real_fast(struct tk_fast *tkf, u64 *mono)
/** /**
* ktime_get_real_fast_ns: - NMI safe and fast access to clock realtime. * ktime_get_real_fast_ns: - NMI safe and fast access to clock realtime.
* *
* See ktime_get_fast_ns() for documentation of the time stamp ordering. * See ktime_get_mono_fast_ns() for documentation of the time stamp ordering.
*/ */
u64 ktime_get_real_fast_ns(void) u64 ktime_get_real_fast_ns(void)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment