Commit 7e1c4058 authored by William Breathitt Gray's avatar William Breathitt Gray Committed by Jonathan Cameron

iio: 104-quad-8: Fix off-by-one errors when addressing IOR

The Input/Output Control register (IOR) is offset by 1 from the
respective channel data register. This patch fixes off-by-one errors
when attempting to write to a channel IOR where the base address was not
properly offset.

Fixes: 28e5d3bb ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8")
Signed-off-by: default avatarWilliam Breathitt Gray <vilhelm.gray@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 47af2c67
...@@ -153,7 +153,7 @@ static int quad8_write_raw(struct iio_dev *indio_dev, ...@@ -153,7 +153,7 @@ static int quad8_write_raw(struct iio_dev *indio_dev,
ior_cfg = val | priv->preset_enable[chan->channel] << 1; ior_cfg = val | priv->preset_enable[chan->channel] << 1;
/* Load I/O control configuration */ /* Load I/O control configuration */
outb(0x40 | ior_cfg, base_offset); outb(0x40 | ior_cfg, base_offset + 1);
return 0; return 0;
case IIO_CHAN_INFO_SCALE: case IIO_CHAN_INFO_SCALE:
...@@ -241,7 +241,7 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev, ...@@ -241,7 +241,7 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
size_t len) size_t len)
{ {
struct quad8_iio *const priv = iio_priv(indio_dev); struct quad8_iio *const priv = iio_priv(indio_dev);
const int base_offset = priv->base + 2 * chan->channel; const int base_offset = priv->base + 2 * chan->channel + 1;
bool preset_enable; bool preset_enable;
int ret; int ret;
unsigned int ior_cfg; unsigned int ior_cfg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment