Commit 7ea7a1e0 authored by Tong Tiangen's avatar Tong Tiangen Committed by Kalle Valo

brcmfmac: Fix a double-free in brcmf_sdio_bus_reset

brcmf_sdiod_remove has been called inside brcmf_sdiod_probe when fails,
so there's no need to call another one. Otherwise, sdiodev->freezer
would be double freed.

Fixes: 7836102a ("brcmfmac: reset SDIO bus on a firmware crash")
Signed-off-by: default avatarTong Tiangen <tongtiangen@huawei.com>
Reviewed-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210601100128.69561-1-tongtiangen@huawei.com
parent ea3f903c
...@@ -4162,7 +4162,6 @@ static int brcmf_sdio_bus_reset(struct device *dev) ...@@ -4162,7 +4162,6 @@ static int brcmf_sdio_bus_reset(struct device *dev)
if (ret) { if (ret) {
brcmf_err("Failed to probe after sdio device reset: ret %d\n", brcmf_err("Failed to probe after sdio device reset: ret %d\n",
ret); ret);
brcmf_sdiod_remove(sdiodev);
} }
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment