Commit 7f8b9657 authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Walleij

gpio: aspeed: fix return value check in aspeed_gpio_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarJoel Stanley <joel@jms.id.au>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent d47529b2
...@@ -413,8 +413,8 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev) ...@@ -413,8 +413,8 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
return -ENXIO; return -ENXIO;
gpio->base = devm_ioremap_resource(&pdev->dev, res); gpio->base = devm_ioremap_resource(&pdev->dev, res);
if (!gpio->base) if (IS_ERR(gpio->base))
return -ENOMEM; return PTR_ERR(gpio->base);
spin_lock_init(&gpio->lock); spin_lock_init(&gpio->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment