Commit 7f988187 authored by Daniel W. S. Almeida's avatar Daniel W. S. Almeida Committed by Mauro Carvalho Chehab

media: pci: cobalt-i2c.c: fix comparison of 0/1 to bool variable

Fix the following coccinelle reports:

drivers/media/pci/cobalt/cobalt-i2c.c:176:16-21: WARNING:
Comparison of 0/1 to bool variable
drivers/media/pci/cobalt/cobalt-i2c.c:180:29-33: WARNING:
Comparison of 0/1 to bool variable
drivers/media/pci/cobalt/cobalt-i2c.c:121:16-21: WARNING:
Comparison of 0/1 to bool variable
drivers/media/pci/cobalt/cobalt-i2c.c:125:29-33: WARNING:
Comparison of 0/1 to bool variable

Found using - Coccinelle (http://coccinelle.lip6.fr)
Signed-off-by: default avatarDaniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 08091fc1
...@@ -118,11 +118,11 @@ static int cobalt_tx_bytes(struct cobalt_i2c_regs __iomem *regs, ...@@ -118,11 +118,11 @@ static int cobalt_tx_bytes(struct cobalt_i2c_regs __iomem *regs,
iowrite8(data[i], &regs->txr_rxr); iowrite8(data[i], &regs->txr_rxr);
/* Setup command */ /* Setup command */
if (i == 0 && start != 0) { if (i == 0 && start) {
/* Write + Start */ /* Write + Start */
cmd = M00018_CR_BITMAP_WR_MSK | cmd = M00018_CR_BITMAP_WR_MSK |
M00018_CR_BITMAP_STA_MSK; M00018_CR_BITMAP_STA_MSK;
} else if (i == len - 1 && stop != 0) { } else if (i == len - 1 && stop) {
/* Write + Stop */ /* Write + Stop */
cmd = M00018_CR_BITMAP_WR_MSK | cmd = M00018_CR_BITMAP_WR_MSK |
M00018_CR_BITMAP_STO_MSK; M00018_CR_BITMAP_STO_MSK;
...@@ -173,11 +173,11 @@ static int cobalt_rx_bytes(struct cobalt_i2c_regs __iomem *regs, ...@@ -173,11 +173,11 @@ static int cobalt_rx_bytes(struct cobalt_i2c_regs __iomem *regs,
for (i = 0; i < len; i++) { for (i = 0; i < len; i++) {
/* Setup command */ /* Setup command */
if (i == 0 && start != 0) { if (i == 0 && start) {
/* Read + Start */ /* Read + Start */
cmd = M00018_CR_BITMAP_RD_MSK | cmd = M00018_CR_BITMAP_RD_MSK |
M00018_CR_BITMAP_STA_MSK; M00018_CR_BITMAP_STA_MSK;
} else if (i == len - 1 && stop != 0) { } else if (i == len - 1 && stop) {
/* Read + Stop */ /* Read + Stop */
cmd = M00018_CR_BITMAP_RD_MSK | cmd = M00018_CR_BITMAP_RD_MSK |
M00018_CR_BITMAP_STO_MSK; M00018_CR_BITMAP_STO_MSK;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment