Commit 7f9ab862 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Lee Jones

leds: spi-byte: Call of_node_put() on error path

Add a missing call to of_node_put(np) on error.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240606173037.3091598-2-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarLee Jones <lee@kernel.org>
parent e1524a62
...@@ -91,7 +91,6 @@ static int spi_byte_probe(struct spi_device *spi) ...@@ -91,7 +91,6 @@ static int spi_byte_probe(struct spi_device *spi)
dev_err(dev, "Device must have exactly one LED sub-node."); dev_err(dev, "Device must have exactly one LED sub-node.");
return -EINVAL; return -EINVAL;
} }
child = of_get_next_available_child(dev_of_node(dev), NULL);
led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL); led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL);
if (!led) if (!led)
...@@ -104,11 +103,13 @@ static int spi_byte_probe(struct spi_device *spi) ...@@ -104,11 +103,13 @@ static int spi_byte_probe(struct spi_device *spi)
led->ldev.max_brightness = led->cdef->max_value - led->cdef->off_value; led->ldev.max_brightness = led->cdef->max_value - led->cdef->off_value;
led->ldev.brightness_set_blocking = spi_byte_brightness_set_blocking; led->ldev.brightness_set_blocking = spi_byte_brightness_set_blocking;
child = of_get_next_available_child(dev_of_node(dev), NULL);
state = of_get_property(child, "default-state", NULL); state = of_get_property(child, "default-state", NULL);
if (state) { if (state) {
if (!strcmp(state, "on")) { if (!strcmp(state, "on")) {
led->ldev.brightness = led->ldev.max_brightness; led->ldev.brightness = led->ldev.max_brightness;
} else if (strcmp(state, "off")) { } else if (strcmp(state, "off")) {
of_node_put(child);
/* all other cases except "off" */ /* all other cases except "off" */
dev_err(dev, "default-state can only be 'on' or 'off'"); dev_err(dev, "default-state can only be 'on' or 'off'");
return -EINVAL; return -EINVAL;
...@@ -123,9 +124,12 @@ static int spi_byte_probe(struct spi_device *spi) ...@@ -123,9 +124,12 @@ static int spi_byte_probe(struct spi_device *spi)
ret = devm_led_classdev_register_ext(&spi->dev, &led->ldev, &init_data); ret = devm_led_classdev_register_ext(&spi->dev, &led->ldev, &init_data);
if (ret) { if (ret) {
of_node_put(child);
mutex_destroy(&led->mutex); mutex_destroy(&led->mutex);
return ret; return ret;
} }
of_node_put(child);
spi_set_drvdata(spi, led); spi_set_drvdata(spi, led);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment