Commit 7fe05e12 authored by Benjamin Mikailenko's avatar Benjamin Mikailenko Committed by Tony Nguyen

ice: Fix VSI rebuild WARN_ON check for VF

In commit b03d519d ("ice: store VF pointer instead of VF ID")
WARN_ON checks were added to validate the vsi->vf pointer and
catch programming errors. However, one check to vsi->vf was missed.
This caused a call trace when resetting VFs.

Fix ice_vsi_rebuild by encompassing VF pointer in WARN_ON check.

Fixes: b03d519d ("ice: store VF pointer instead of VF ID")
Signed-off-by: default avatarBenjamin Mikailenko <benjamin.mikailenko@intel.com>
Tested-by: default avatarMarek Szlosek <marek.szlosek@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 84ba2890
...@@ -3181,7 +3181,7 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, bool init_vsi) ...@@ -3181,7 +3181,7 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, bool init_vsi)
pf = vsi->back; pf = vsi->back;
vtype = vsi->type; vtype = vsi->type;
if (WARN_ON(vtype == ICE_VSI_VF) && !vsi->vf) if (WARN_ON(vtype == ICE_VSI_VF && !vsi->vf))
return -EINVAL; return -EINVAL;
ice_vsi_init_vlan_ops(vsi); ice_vsi_init_vlan_ops(vsi);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment