Commit 8097cf2f authored by Randy Dunlap's avatar Randy Dunlap Committed by Greg Kroah-Hartman

usb: gadget: udc: amd5536 depends on HAS_DMA

USB_AMD5536UDC should depend on HAS_DMA since it selects USB_SNP_CORE,
which depends on HAS_DMA and since 'select' does not follow any
dependency chains.

Fixes this kconfig warning:

WARNING: unmet direct dependencies detected for USB_SNP_CORE
  Depends on [n]: USB_SUPPORT [=y] && USB_GADGET [=y] && (USB_AMD5536UDC [=y] || USB_SNP_UDC_PLAT [=n]) && HAS_DMA [=n]
  Selected by [y]:
  - USB_AMD5536UDC [=y] && USB_SUPPORT [=y] && USB_GADGET [=y] && USB_PCI [=y]

Fixes: 97b3ffa2 ("usb: gadget: udc: amd5536: split core and PCI layer")
Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20220709013601.7536-1-rdunlap@infradead.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8affe37c
...@@ -311,7 +311,7 @@ source "drivers/usb/gadget/udc/bdc/Kconfig" ...@@ -311,7 +311,7 @@ source "drivers/usb/gadget/udc/bdc/Kconfig"
config USB_AMD5536UDC config USB_AMD5536UDC
tristate "AMD5536 UDC" tristate "AMD5536 UDC"
depends on USB_PCI depends on USB_PCI && HAS_DMA
select USB_SNP_CORE select USB_SNP_CORE
help help
The AMD5536 UDC is part of the AMD Geode CS5536, an x86 southbridge. The AMD5536 UDC is part of the AMD Geode CS5536, an x86 southbridge.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment