Commit 809aa504 authored by James Bottomley's avatar James Bottomley Committed by Linus Torvalds

mca: fix bus matching

There's a bug in the MCA bus matching algorithm in that it promotes from
signed short to int before comparing with the actual id and does sign
extension on anything > 0x7fff (which means that pos ids > 0x7fff never get
correctly matched).
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 818563dc
...@@ -47,7 +47,7 @@ static int mca_bus_match (struct device *dev, struct device_driver *drv) ...@@ -47,7 +47,7 @@ static int mca_bus_match (struct device *dev, struct device_driver *drv)
{ {
struct mca_device *mca_dev = to_mca_device (dev); struct mca_device *mca_dev = to_mca_device (dev);
struct mca_driver *mca_drv = to_mca_driver (drv); struct mca_driver *mca_drv = to_mca_driver (drv);
const short *mca_ids = mca_drv->id_table; const unsigned short *mca_ids = mca_drv->id_table;
int i; int i;
if (!mca_ids) if (!mca_ids)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment