Commit 80ad54a6 authored by Guo Zhengkui's avatar Guo Zhengkui Committed by Greg Kroah-Hartman

drivers: comedi: replace ternary operator with min()

Fix the following coccicheck warning:

drivers/comedi/drivers.c:857:12-13: WARNING opportunity for min().

min() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGuo Zhengkui <guozhengkui@vivo.com>
Link: https://lore.kernel.org/r/20220513071608.49047-1-guozhengkui@vivo.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7394d2eb
...@@ -854,7 +854,7 @@ int comedi_load_firmware(struct comedi_device *dev, ...@@ -854,7 +854,7 @@ int comedi_load_firmware(struct comedi_device *dev,
release_firmware(fw); release_firmware(fw);
} }
return ret < 0 ? ret : 0; return min(ret, 0);
} }
EXPORT_SYMBOL_GPL(comedi_load_firmware); EXPORT_SYMBOL_GPL(comedi_load_firmware);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment