Commit 8130b9d5 authored by Dongli Zhang's avatar Dongli Zhang Committed by Boris Ostrovsky

xenbus: req->err should be updated before req->state

This patch adds the barrier to guarantee that req->err is always updated
before req->state.

Otherwise, read_reply() would not return ERR_PTR(req->err) but
req->body, when process_writes()->xb_write() is failed.
Signed-off-by: default avatarDongli Zhang <dongli.zhang@oracle.com>
Link: https://lore.kernel.org/r/20200303221423.21962-2-dongli.zhang@oracle.comReviewed-by: default avatarJulien Grall <jgrall@amazon.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
parent 1b6a51e8
...@@ -397,6 +397,8 @@ static int process_writes(void) ...@@ -397,6 +397,8 @@ static int process_writes(void)
if (state.req->state == xb_req_state_aborted) if (state.req->state == xb_req_state_aborted)
kfree(state.req); kfree(state.req);
else { else {
/* write err, then update state */
virt_wmb();
state.req->state = xb_req_state_got_reply; state.req->state = xb_req_state_got_reply;
wake_up(&state.req->wq); wake_up(&state.req->wq);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment