Commit 81ae962d authored by Anton Vasilyev's avatar Anton Vasilyev Committed by Greg Kroah-Hartman

misc: ti-st: Fix memory leak in the error path of probe()

Free resources instead of direct return of the error code if kim_probe
fails.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarAnton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8c64b39
...@@ -755,14 +755,14 @@ static int kim_probe(struct platform_device *pdev) ...@@ -755,14 +755,14 @@ static int kim_probe(struct platform_device *pdev)
err = gpio_request(kim_gdata->nshutdown, "kim"); err = gpio_request(kim_gdata->nshutdown, "kim");
if (unlikely(err)) { if (unlikely(err)) {
pr_err(" gpio %d request failed ", kim_gdata->nshutdown); pr_err(" gpio %d request failed ", kim_gdata->nshutdown);
return err; goto err_sysfs_group;
} }
/* Configure nShutdown GPIO as output=0 */ /* Configure nShutdown GPIO as output=0 */
err = gpio_direction_output(kim_gdata->nshutdown, 0); err = gpio_direction_output(kim_gdata->nshutdown, 0);
if (unlikely(err)) { if (unlikely(err)) {
pr_err(" unable to configure gpio %d", kim_gdata->nshutdown); pr_err(" unable to configure gpio %d", kim_gdata->nshutdown);
return err; goto err_sysfs_group;
} }
/* get reference of pdev for request_firmware /* get reference of pdev for request_firmware
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment